Add Shikra (QCM2390) display support for CQS and CQM targets by naala-qcom · Pull Request #679 · qualcomm-linux/kernel

naala-qcom · 2026-06-09T17:01:56Z

This patch series enables the display in shikra for CQM and CQS target

Depends-On:

CRs-Fixed: 4566067

qlijarvis · 2026-06-09T18:36:08Z

PR #679 — validate-patch

PR: #679

Verdict	Issues	Detailed Report
⚠️	0	Full report

Final Summary

Lore link present:
- Patch 01: No — vendor revert, no lore link expected
- Patches 02-20: Yes — FROMLIST with lore.kernel.org links
- Patches 21-28: No — new patches not yet posted upstream
Lore link matches PR commits:
- Patches 02-20: Cannot verify — lore links point to future dates (2026-06-04/05)
- Other patches: N/A
Upstream patch status:
- Patches 02-20: Cannot determine — future-dated links
- Patches 21-28: Not posted upstream yet (patches 23-24 have maintainer reviews suggesting they may be in review)
PR present in qcom-next: Not checked — would require access to qcom-next branch

Recommendation: Before merging, remove all Change-Id tags from patches 2-14, fix the typo in patch 01, and add EOF newline to patch 22. The FROMLIST patches appear to be from an upcoming upstream submission series.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #679 - Shikra Display Subsystem Support (28 patches)
Upstream commit: Multiple lore.kernel.org links (FROMLIST patches 2-20) + vendor patches (1, 21-28)
Verdict: ⚠️ PARTIAL

Summary by Patch Type

Patch 01: Vendor revert (no lore link expected)
Patches 02-20: FROMLIST patches with lore links
Patches 21-28: New patches without lore links (not yet posted upstream)

Commit Message Issues

Patch Issue Severity

01 Typo: "code chages" → "code changes" ⚠️ Minor

02-14 Change-Id tags present (Gerrit artifact) ❌ Must remove

02-20 FROMLIST patches - lore links point to future dates (2026-06-04/05) ⚠️ Cannot verify

Authorship & Tags

Check Status Note

Author preserved ✅ Imran Shaik, Nabige Aala, Arpit Saini

Signed-off-by present ✅ All patches have SOB

Reviewed-by tags ✅ Patches 23-24 have upstream reviews (Dmitry Baryshkov, Krzysztof Kozlowski, Loic Poulain)

Change-Id tags ❌ Present in patches 2-14 (must be removed before upstream submission)

Patch Categories

Category 1: Vendor Revert (Patch 01)

Subject: "clk: qcom: Revert older series Shikra GPUCC/DISPCC changes"

Status: ⚠️ Typo in commit body ("chages")

Lore link: N/A (vendor-only revert)

Category 2: FROMLIST Clock Patches (02-20)

All have Link: tags pointing to lore.kernel.org

Series IDs: 20260604-shikra-dispcc-gpucc-v4-* and 20260605-shikra-*

Status: ⚠️ Cannot verify (future dates), ❌ Change-Id tags must be removed

Patches cover: gcc-qcm2290, dispcc, gpucc, audiocorecc, DT bindings

Category 3: New Display Patches (21-28)

No lore links (not yet posted upstream)

Patches:

21: dt-bindings: ILI7807S panel controller

22: drm/panel: ILI7807S driver

23: dt-bindings: Shikra MDSS (has Reviewed-by tags)

24: soc: qcom: ubwc config (has Reviewed-by tag)

25-28: arm64: dts additions and defconfig

Issues

Critical (Must Fix):

Change-Id tags in patches 2-14 - These are Gerrit artifacts and must be removed before upstream submission. They are not acceptable in kernel patches.

Minor (Should Fix):
2. Typo in patch 01 - "code chages" should be "code changes"
3. Missing newline at EOF - Patch 22 (panel driver) ends without newline: MODULE_LICENSE("GPL");\ No newline at end of file

Cannot Verify:
4. FROMLIST patches reference future dates - Lore links point to 2026-06-04 and 2026-06-05, which don't exist yet. Cannot verify diff faithfulness or upstream acceptance status.

Diff Spot Checks

File Status Notes

drivers/clk/qcom/gcc-qcm2290.c ⚠️ Cannot verify against lore (future date)

drivers/gpu/drm/panel/panel-ilitek-ili7807s.c ⚠️ Missing EOF newline

arch/arm64/boot/dts/qcom/shikra.dtsi ✅ Looks reasonable for new SoC support

arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ✅ Board-specific display enablement

Verdict

Patches 02-14: ❌ MUST FIX - Remove Change-Id tags before merging. These are Gerrit artifacts not acceptable in upstream kernel patches.

Patch 01: ⚠️ SHOULD FIX - Fix typo "chages" → "changes"

Patch 22: ⚠️ SHOULD FIX - Add newline at end of file

Patches 21-28: ✅ ACCEPTABLE - New patches not yet posted upstream. Patches 23-24 already have upstream maintainer reviews.

Overall: The PR mixes vendor reverts, FROMLIST patches, and new patches. The FROMLIST patches contain Change-Id tags that must be removed. Cannot verify faithfulness to upstream due to future-dated lore links.

Final Summary

Lore link present:

Patch 01: No — vendor revert, no lore link expected

Patches 02-20: Yes — FROMLIST with lore.kernel.org links

Patches 21-28: No — new patches not yet posted upstream

Lore link matches PR commits:

Patches 02-20: Cannot verify — lore links point to future dates (2026-06-04/05)

Other patches: N/A

Upstream patch status:

Patches 02-20: Cannot determine — future-dated links

Patches 21-28: Not posted upstream yet (patches 23-24 have maintainer reviews suggesting they may be in review)

PR present in qcom-next: Not checked — would require access to qcom-next branch

Recommendation: Before merging, remove all Change-Id tags from patches 2-14, fix the typo in patch 01, and add EOF newline to patch 22. The FROMLIST patches appear to be from an upcoming upstream submission series.

qlijarvis · 2026-06-09T18:36:09Z

PR #679 — checker-log-analyzer

PR: #679
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27222640163

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	13 commits with Gerrit Change-Id; 1 commit with indentation errors (60 lines)
dt-binding-check	✅	Passed
dtb-check	❌	DTS syntax error (missing label) + schema validation failures
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	9 commits missing required prefix; 2 commits differ from upstream Link
tag-check	N/A	Not applicable for this branch
qcom-next-check	⚠️	20 FROMLIST commits present (expected for qcom-next)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #679 - Shikra GPUCC/DISPCC and Display Subsystem Support (28 commits)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27222640163

Checker Result Summary

checkpatch ❌ 13 commits with Gerrit Change-Id; 1 commit with indentation errors (60 lines)

dt-binding-check ✅ Passed

dtb-check ❌ DTS syntax error (missing label) + schema validation failures

sparse-check ✅ Passed

check-uapi-headers ✅ Passed

check-patch-compliance ❌ 9 commits missing required prefix; 2 commits differ from upstream Link

tag-check N/A Not applicable for this branch

qcom-next-check ⚠️ 20 FROMLIST commits present (expected for qcom-next)

❌ checkpatch

Root cause: 13 commits contain Gerrit Change-Id: trailers that must be removed before upstream submission, and 1 commit has 60 lines with space indentation instead of tabs.

Failure details:
ERROR: Remove Gerrit Change-Id's before submitting upstream

Affected commits (13):
- 71ebdda8cca7 FROMLIST: clk: qcom: gcc-qcm2290: Keep the critical clocks always-on from probe
- cd0a8f02fa5d FROMLIST: dt-bindings: clock: qcom,qcm2290-dispcc: Add DSI1 PHY and sleep clocks
- 6e1782a40219 FROMLIST: dt-bindings: clock: qcom: Add Qualcomm Shikra Display clock controller
- 0f47b7f3b4f1 FROMLIST: dt-bindings: clock: qcom: Add Qualcomm Shikra GPU clock controller
- b473f6a29cff FROMLIST: clk: qcom: dispcc-qcm2290: Move to the latest common qcom_cc_probe() model
- 4ff200a789c3 FROMLIST: clk: qcom: dispcc-qcm2290: Switch to DT index based clk lookup
- 4ebc9d18b40e FROMLIST: clk: qcom: dispcc-qcm2290: Update GDSC *wait_val values and flags
- 85c0d8c5ee39 FROMLIST: clk: qcom: gpucc-qcm2290: Move to the latest common qcom_cc_probe() model
- ec6ae89ebd72 FROMLIST: clk: qcom: gpucc-qcm2290: Park RCG's clk source at XO during disable
- (4 more commits)

ERROR: code indent should use tabs where possible (60 occurrences)

Affected commit:
- 33051f09593b dt-bindings: display: msm: qcm2290: Add Shikra MDSS
Fix:
Remove all Change-Id: lines from commit messages:
git rebase -i HEAD~28
# Mark affected commits for 'edit'
# For each commit:
git commit --amend
# Delete the "Change-Id: I..." line from the commit message
git rebase --continue
Fix indentation in dt-bindings: display: msm: qcm2290: Add Shikra MDSS:
git show 33051f09593b > /tmp/patch.diff
# Identify the file with space indentation (likely a YAML binding)
# Replace leading spaces with tabs in the affected sections
# Amend the commit with corrected indentation
Reproduce locally:
git fetch origin pull/679/head:pr679
git checkout pr679
./scripts/checkpatch.pl --git HEAD~28..HEAD
❌ dtb-check

Root cause: DTS file arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts:136 references undefined label usb_qmpphy_out, causing a fatal DTC syntax error. Additionally, multiple schema validation failures exist for panel and MDSS nodes.

Failure details:
Error: ../arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts:136.1-16 Label or path usb_qmpphy_out not found
FATAL ERROR: Syntax error parsing input tree
make[4]: *** [../scripts/Makefile.dtbs:132: arch/arm64/boot/dts/qcom/shikra-cqs-evk.dtb] Error 1

Schema validation failures:
1. shikra-cqm-evk.dtb: display-subsystem@5e00000 (qcom,shikra-mdss): 
   iommus: [[31, 1056, 2]] is too short

2. shikra-cqm-evk.dtb: panel@0 (dlc,dlc0697):
   - 'bias-supply', 'enable-gpios', 'vddio-supply' do not match any of the regexes
   - compatible: ['dlc,dlc0697'] is too short (needs fallback compatible)
   - Missing required properties: 'vddi-supply', 'avdd-supply', 'avee-supply'

3. shikra-iqs-evk.dtb: display-subsystem@5e00000 (qcom,shikra-mdss):
   iommus: [[31, 1056, 2]] is too short
Fix:

Fix missing label in shikra-cqs-evk.dts:136:

The label usb_qmpphy_out is referenced but not defined. Either:

Define the label in the USB QMP PHY node, OR

Remove/comment the reference if USB support is not yet ready for this board

Fix panel binding in shikra-cqm-evk.dts:

Add fallback compatible: compatible = "dlc,dlc0697", "ilitek,ili7807s";

Rename supplies to match schema:

vddio-supply → vddi-supply

Add missing avdd-supply and avee-supply

Remove bias-supply and enable-gpios if not in schema, or update the binding YAML

Fix MDSS iommus property:

The iommus property expects more than 3 elements. Check qcom,qcm2290-mdss.yaml schema for the correct format (likely needs additional IOMMU stream IDs)

Reproduce locally:
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- defconfig
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/shikra-cqs-evk.dtb
make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- CHECK_DTBS=y qcom/shikra-cqm-evk.dtb
❌ check-patch-compliance

Root cause: 9 commits lack the required subject prefix (UPSTREAM:, FROMLIST:, BACKPORT:, or FROMGIT:), and 2 FROMLIST commits have patch content that differs from the upstream lore.kernel.org link referenced in the commit message.

Failure details:
Commits missing required prefix (9):
1. clk: qcom: Revert older series Shikra GPUCC/DISPCC changes
2. dt-bindings: display: panel: add Ilitek ILI7807S panel controller
3. drm/panel: add Ilitek ILI7807S panel driver
4. dt-bindings: display: msm: qcm2290: Add Shikra MDSS
5. soc: qcom: ubwc: Add Shikra UBWC config
6. arm64: dts: qcom: shikra: Add MDSS display subsystem
7. arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
8. arm64: defconfig: Enable ILI7807S DSI panel driver
9. arm64: dts: qcom: shikra-cqs-evk: Enable display

Commits with content mismatch (2):
- FROMLIST: dt-bindings: clock: qcom: Add the definition for the USB3 DP PHY reset
- FROMLIST: clk: qcom: gcc-shikra: Add USB3 DP PHY reset and LPASS clocks
  → "Change is different from the one mentioned in Link"
Fix:

Add required prefix to 9 commits:

If these are Qualcomm-internal changes not intended for upstream: prefix with QCOM: or similar internal tag

If these are new patches being prepared for upstream: prefix with FROMLIST: and add a Link: tag to the lore.kernel.org posting

If reverting previous work: consider REVERT: or QCOM: prefix

Fix content mismatch for 2 FROMLIST commits:

Option A: Update the Link: tag to point to the correct upstream version that matches the patch content

Option B: Revert local changes to match the upstream patch exactly, then apply local modifications as separate commits with appropriate prefixes

Reproduce locally:
# Check for required prefixes
git log --oneline HEAD~28..HEAD | grep -v -E "^[0-9a-f]+ (UPSTREAM|FROMLIST|BACKPORT|FROMGIT|QCOM):"

# Validate FROMLIST commits against lore links
# (requires check-patch-compliance script from kernel-config repo)
Verdict

11 blockers must be fixed before merge:

Checkpatch (13 commits): Remove all Gerrit Change-Id: trailers

Checkpatch (1 commit): Fix tab indentation in YAML binding

dtb-check (critical): Fix undefined usb_qmpphy_out label in shikra-cqs-evk.dts

dtb-check (schema): Fix panel compatible, supplies, and MDSS iommus properties

check-patch-compliance (9 commits): Add required subject prefixes

check-patch-compliance (2 commits): Resolve FROMLIST content mismatch with upstream links

Recommended workflow:

Fix the critical DTS syntax error first (blocker for dtb-check)

Remove Gerrit Change-IDs and fix indentation (automated fixes)

Add missing subject prefixes (policy decision needed: QCOM: vs FROMLIST:)

Resolve FROMLIST content mismatches

Fix remaining schema validation issues

Re-run CI to verify all checkers pass

naala-qcom · 2026-06-10T05:14:45Z

qli-2.0 GA Critical Fix

qswat-orbit-external · 2026-06-10T05:58:23Z

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4566067 on any of the following entities:

Entities:

kernel.qli.2.0

CR: 4566067

Please ensure the CR has a change task associated with at least one of the entities for this branch.

qswat-orbit-external · 2026-06-10T07:08:02Z

Merge Check Failed: No Change Task Found

No associated change tasks found for CR 4566067 on any of the following entities:

Entities:

kernel.qli.2.0

CR: 4566067

Please ensure the CR has a change task associated with at least one of the entities for this branch.

qswat-orbit-external · 2026-06-10T07:20:32Z

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-10T07:26:48Z

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

sgaud-quic · 2026-06-10T11:13:35Z

@naala-qcom please rebase the PR on tip.

qswat-orbit-external · 2026-06-10T11:21:50Z

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-10T11:25:22Z

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

shashim-quic

prefix all commits with valid tags (FROMLIST etc.)
include a valid Link: tag in commit log

qswat-orbit-external · 2026-06-10T15:06:18Z

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-12T01:51:41Z

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-12T11:52:05Z

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-14T05:06:19Z

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qswat-orbit-external · 2026-06-15T04:49:08Z

Merge Check Failed: CR Not Eligible for Merge

CR 4566067 is not eligible for merge.

The parent software image for kernel.qli.2.0 is not development complete.

Entity: kernel.qli.2.0
CR: 4566067
Reason: CR_CANNOT_MERGE

Please ensure the CR passes both CCT (ComponentChangeTasks) and ICT (Integration Change Tasks) validations.

qlijarvis · 2026-06-16T16:40:27Z

PR #679 — validate-patch

PR: #679

Verdict	Issues	Detailed Report
⚠️	0	Full report

Final Summary

Lore link present: Yes for 3 FROMLIST patches (04, 05, 06); No for 7 PENDING patches (expected and correct)
Lore link matches PR commits: Cannot verify - lore links are dated 2026-06-09 and 2026-06-15 (future dates), so upstream patches don't exist yet to compare against
Upstream patch status: FROMLIST patches are marked as under review (not yet merged); PENDING patches are vendor-specific and not posted upstream
PR present in qcom-next: Not checked - this is a validation of patch correctness, not integration status

Recommendation: Fix the indentation issue in patch 08 before merging. The grammar error in patch 05 is minor but should be corrected for upstream submission quality.

Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #679 - Shikra GPU and Display Support (10 patches)
Upstream commits: 3 FROMLIST patches with lore links; 7 PENDING patches
Verdict: ⚠️ PARTIAL - Minor issues found

Summary by Patch

Patch 01/10: PENDING: arm64: dts: qcom: shikra: Add A704 GPU support

Check Status Note

Subject format ✅ Clear, descriptive

Body preserves rationale ✅ Adequate description

Fixes tag present/correct N/A New feature, not a fix

Authorship preserved ✅ Aditya Sherawat

Backport note N/A PENDING patch

Verdict: ✅ PASS - Well-formed PENDING patch for new GPU support

Patch 02/10: PENDING: arm64: dts: qcom: shikra: Add GPU cooling

Check Status Note

Subject format ✅ Clear, descriptive

Body preserves rationale ✅ Explains thermal throttling at 115°C

Fixes tag present/correct N/A New feature

Authorship preserved ✅ Aastha Pandey

Backport note N/A PENDING patch

Verdict: ✅ PASS - Well-formed thermal management patch

Patch 03/10: PENDING: arm64: dts: qcom: shikra: Add Adreno SMMU node

Check Status Note

Subject format ✅ Clear, descriptive

Body preserves rationale ✅ Brief but adequate

Fixes tag present/correct N/A New feature

Authorship preserved ⚠️ Author: Komal Bajaj; Co-authors: Bibek Kumar Patro, Imran Shaik (all have SOB)

Backport note N/A PENDING patch

Verdict: ✅ PASS - Multiple contributors properly credited

Patch 04/10: FROMLIST: dt-bindings: arm-smmu: Document GPU SMMU for Shikra SoC

Check Status Note

Subject matches upstream ✅ Proper dt-bindings format

Body preserves rationale ✅ Brief, appropriate for binding addition

Fixes tag present/correct N/A New binding

Authorship preserved ⚠️ Author: Bibek Kumar Patro; Co-author: Akhil P Oommen (both have SOB)

Backport note ✅ FROMLIST with lore link

Lore link ✅ https://lore.kernel.org/lkml/20260615-shikra-gpu-v2-3-2f2d1347c3fb@oss.qualcomm.com/

Reviewed-by tag ✅ Krzysztof Kozlowski

Diff:

File Status Notes

Documentation/devicetree/bindings/iommu/arm,smmu.yaml ✅ Single line addition: qcom,shikra-smmu-500

Verdict: ✅ PASS - Proper FROMLIST patch with review tag

Patch 05/10: FROMLIST: dt-bindings: display/msm/gpu: Add support for A704 GPU

Check Status Note

Subject matches upstream ✅ Proper dt-bindings format

Body preserves rationale ⚠️ Grammar error: "found Shikra SoC" → should be "found in Shikra SoC"

Fixes tag present/correct N/A New binding

Authorship preserved ⚠️ Author: Aditya Sherawat; Original author: Akhil P Oommen (both have SOB)

Backport note ✅ FROMLIST with lore link

Lore link ✅ https://lore.kernel.org/lkml/20260609-shikra-gpu-v1-1-9d0e09cab115@oss.qualcomm.com/

Reviewed-by tag ✅ Krzysztof Kozlowski

Diff:

File Status Notes

Documentation/devicetree/bindings/display/msm/gpu.yaml ✅ Single line addition: qcom,adreno-07000400

Issues:

Commit message has grammar error: "Adreno A704 GPU found Shikra SoC" missing "in"

Verdict: ⚠️ PARTIAL - Minor grammar issue in commit message

Patch 06/10: FROMLIST: drm/msm/adreno: Add support for A704 GPU

Check Status Note

Subject matches upstream ✅ Proper driver subsystem format

Body preserves rationale ⚠️ Same grammar error: "found in Shikra" (correct) vs patch 05

Fixes tag present/correct N/A New feature

Authorship preserved ⚠️ Author: Aditya Sherawat; Original author: Akhil P Oommen (both have SOB)

Backport note ✅ FROMLIST with lore link

Lore link ✅ https://lore.kernel.org/lkml/20260609-shikra-gpu-v1-2-9d0e09cab115@oss.qualcomm.com/

Reviewed-by tag ✅ Konrad Dybcio

Diff:

File Status Notes

drivers/gpu/drm/msm/adreno/a6xx_catalog.c ✅ Adds 0x07000400 chipid to existing A702 entry

Verdict: ✅ PASS - Clean driver patch with review tag

Patch 07/10: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem

Check Status Note

Subject format ✅ Clear, descriptive

Body preserves rationale ✅ Detailed explanation of DPU 6.5 reuse

Fixes tag present/correct N/A New feature

Authorship preserved ✅ Nabige Aala

Backport note N/A PENDING patch

Diff:

File Status Notes

arch/arm64/boot/dts/qcom/shikra.dtsi ✅ Adds MDSS, MDP, DSI controller, DSI PHY nodes (203 lines)

Verdict: ✅ PASS - Comprehensive display subsystem addition

Patch 08/10: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel

Check Status Note

Subject format ✅ Clear, descriptive

Body preserves rationale ✅ Explains regulator voltage requirement

Fixes tag present/correct N/A New feature

Authorship preserved ✅ Nabige Aala

Backport note N/A PENDING patch

Diff:

File Status Notes

arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts ⚠️ Indentation inconsistency: lcd_bias node uses spaces instead of tabs

Issues:

Lines 27-36 in the added lcd_bias regulator node use spaces for indentation instead of tabs

Rest of the file and kernel DTS style uses tabs

This will likely fail checkpatch.pl with "code indent should use tabs where possible"

Verdict: ⚠️ PARTIAL - Whitespace/indentation issue

Patch 09/10: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver

Check Status Note

Subject format ✅ Clear, descriptive

Body preserves rationale ✅ Explains usage on CQM EVK

Fixes tag present/correct N/A Config change

Authorship preserved ✅ Nabige Aala (naala@qti.qualcomm.com)

Backport note N/A PENDING patch

Diff:

File Status Notes

arch/arm64/configs/defconfig ✅ Single line addition: CONFIG_DRM_PANEL_ILITEK_ILI7807S=m

Verdict: ✅ PASS - Clean defconfig update

Patch 10/10: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display

Check Status Note

Subject format ✅ Clear, descriptive

Body preserves rationale ✅ Brief but adequate

Fixes tag present/correct N/A New feature

Authorship preserved ✅ Nabige Aala (naala@qti.qualcomm.com)

Backport note N/A PENDING patch

Diff:

File Status Notes

arch/arm64/boot/dts/qcom/shikra-cqs-evk.dts ✅ Consistent tab indentation (unlike patch 08)

Verdict: ✅ PASS - Clean board enablement

Overall Issues

Patch 05 - Grammar error: Commit message has "Adreno A704 GPU found Shikra SoC" (missing "in")

Patch 08 - Indentation: lcd_bias regulator node uses spaces instead of tabs (lines 27-36)

Authorship chain: Patches 05 and 06 show Aditya Sherawat as author but Akhil P Oommen as first SOB, suggesting Akhil was the original author. This is acceptable if Aditya is carrying the patch forward, but the authorship should ideally match the original author with a Co-developed-by tag.

Verdict

⚠️ PARTIAL PASS - Series is mostly well-formed but has minor issues:

Must fix:

Patch 08: Fix indentation in lcd_bias regulator node (use tabs, not spaces)

Should fix:

Patch 05: Fix grammar in commit message ("found in Shikra SoC")

Consider:

Patches 05-06: If Akhil P Oommen is the original author, consider using From: with his authorship and adding Co-developed-by: / Signed-off-by: for Aditya Sherawat

Final Summary

Lore link present: Yes for 3 FROMLIST patches (04, 05, 06); No for 7 PENDING patches (expected and correct)

Lore link matches PR commits: Cannot verify - lore links are dated 2026-06-09 and 2026-06-15 (future dates), so upstream patches don't exist yet to compare against

Upstream patch status: FROMLIST patches are marked as under review (not yet merged); PENDING patches are vendor-specific and not posted upstream

PR present in qcom-next: Not checked - this is a validation of patch correctness, not integration status

Recommendation: Fix the indentation issue in patch 08 before merging. The grammar error in patch 05 is minor but should be corrected for upstream submission quality.

qlijarvis · 2026-06-16T16:40:29Z

PR #679 — checker-log-analyzer

PR: #679
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/27630048451

Checker	Result	Summary
Checker	Result	Summary
checkpatch	❌	57 errors: spaces used instead of tabs in DTS files
dt-binding-check	✅	Passed
dtb-check	❌	GPU reg-names schema mismatch, MDSS iommus too short, panel compatible too short
sparse-check	✅	Passed
check-uapi-headers	✅	Passed
check-patch-compliance	❌	7 PENDING commits missing prefix; 1 FROMLIST patch differs from upstream
tag-check	⏭️	N/A (not qcom-next branch)
qcom-next-check	⏭️	N/A (not qcom-next branch)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #679 - Add Shikra GPU and Display support (10 commits)
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/27630048451

Checker Result Summary

checkpatch ❌ 57 errors: spaces used instead of tabs in DTS files

dt-binding-check ✅ Passed

dtb-check ❌ GPU reg-names schema mismatch, MDSS iommus too short, panel compatible too short

sparse-check ✅ Passed

check-uapi-headers ✅ Passed

check-patch-compliance ❌ 7 PENDING commits missing prefix; 1 FROMLIST patch differs from upstream

tag-check ⏭️ N/A (not qcom-next branch)

qcom-next-check ⏭️ N/A (not qcom-next branch)

❌ checkpatch

Root cause: Patch 08/10 (shikra-cqm-evk: Enable display and add ili7807s panel) uses spaces instead of tabs for indentation in DTS file.

Failure details:
ERROR: code indent should use tabs where possible
#27: FILE: arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts:27:
+                compatible = "regulator-fixed";$

WARNING: please, no spaces at the start of a line
#27: FILE: arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts:27:
+                compatible = "regulator-fixed";$
This pattern repeats 57 times across the lcd_bias regulator node, &mdss, &pm4125_l5, &mdss_dsi0, and &tlmm sections.

Fix: Replace all leading spaces with tabs in arch/arm64/boot/dts/qcom/shikra-cqm-evk.dts:27-89. The regulator node and all device tree property lines must use tabs for indentation, not spaces.

Reproduce locally:
scripts/checkpatch.pl --git HEAD~3..HEAD
❌ dtb-check

Root cause: Three distinct schema validation failures introduced by the GPU and display patches.

Failure details:

GPU reg-names mismatch (affects all shikra DTBs):
gpu@5900000 (qcom,adreno-07000400): reg-names:1: 'cx_dbgc' was expected
gpu@5900000 (qcom,adreno-07000400): reg-names: ['kgsl_3d0_reg_memory', 'cx_mem', 'cx_dbgc'] is too long
	from schema $id: http://devicetree.org/schemas/display/msm/gpu.yaml#
The GPU node in shikra.dtsi defines 3 reg-names (kgsl_3d0_reg_memory, cx_mem, cx_dbgc), but the schema expects only 2 for this GPU compatible.

MDSS iommus property too short (affects all shikra DTBs):
display-subsystem@5e00000 (qcom,shikra-mdss): iommus: [[34, 1056, 2]] is too short
	from schema $id: http://devicetree.org/schemas/display/msm/qcom,qcm2290-mdss.yaml#
The MDSS node has only one iommus entry, but the schema expects more.

Panel compatible string too short (affects shikra-cqm-evk and shikra-cqs-evk):
panel@0 (dlc,dlc0697): compatible: ['dlc,dlc0697'] is too short
	from schema $id: http://devicetree.org/schemas/display/panel/ilitek,ili7807s.yaml#
The panel node has only "dlc,dlc0697" but the schema expects a fallback compatible (e.g., "dlc,dlc0697", "ilitek,ili7807s").

Fix:

Update Documentation/devicetree/bindings/display/msm/gpu.yaml to allow 3 reg-names for qcom,adreno-07000400, OR remove the third reg entry (cx_dbgc) from the GPU node in shikra.dtsi if it's not needed.

Add missing iommus entries to the MDSS node in shikra.dtsi, or update the binding to allow a single iommus entry for shikra-mdss.

Add a fallback compatible to the panel nodes: compatible = "dlc,dlc0697", "ilitek,ili7807s";

Reproduce locally:
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/gpu.yaml
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.yaml
make dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/panel/ilitek,ili7807s.yaml
❌ check-patch-compliance

Root cause: Seven commits use PENDING: prefix (not allowed), and one FROMLIST commit differs from its upstream link.

Failure details:

PENDING prefix violations (7 commits):
Checking commit: PENDING: arm64: dts: qcom: shikra: Add A704 GPU support
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra: Add GPU cooling
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra: Add Adreno SMMU node
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver
Commit summary does not start with a required prefix

Checking commit: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display
Commit summary does not start with a required prefix
FROMLIST patch mismatch (1 commit):
Checking commit: FROMLIST: dt-bindings: arm-smmu: Document GPU SMMU for Shikra SoC
Change is different from the one mentioned in Link
Patch 04/10 claims to be from https://lore.kernel.org/lkml/20260615-shikra-gpu-v2-3-2f2d1347c3fb@oss.qualcomm.com/ but the diff doesn't match the upstream version.

Fix:

Replace PENDING: prefix with BACKPORT:, FROMGIT:, FROMLIST:, or UPSTREAM: as appropriate for the 7 commits.

For patch 04/10, either update the patch to exactly match the lore link, or update the Link: tag to point to the correct version.

Reproduce locally:
git clone https://github.com/qualcomm-linux/kernel-checkers.git
bash kernel-checkers/check-patch-compliance.sh --kernel-src . --base <base-sha> --head <head-sha>
Verdict

3 blockers must be fixed:

checkpatch: Fix indentation (spaces → tabs) in shikra-cqm-evk.dts

dtb-check: Resolve GPU reg-names, MDSS iommus, and panel compatible schema mismatches

check-patch-compliance: Remove PENDING: prefix from 7 commits and fix FROMLIST patch mismatch

Add the SoC-level display subsystem nodes for Shikra: MDSS wrapper, DPU display controller, DSI host controller, and 14nm DSI PHY. Shikra uses DPU 6.5 hardware (same as QCM2290). Platform-specific compatible strings are used as the primary match with QCM2290 fallbacks to reuse the existing driver support. The dispcc clock inputs for the DSI byte and pixel PLLs are wired from mdss_dsi0_phy. Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>

…7807s panel Enable the Shikra MDSS display subsystem on the CQM EVK board and add the ili7807s panel node. Pin pm4125_l5 to 1.232V with regulator-allow-set-load for DSI PHY PLL stability. Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>

Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module, used on the Shikra CQM EVK board. Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>

Enable the DLC0697 MIPI DSI display panel on the Shikra CQS EVK. Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>

naala-qcom requested review from a team, Komal-Bajaj, aiquny and quic-kaushalk June 9, 2026 17:01

sgaud-quic added this to the qli-2.0 GA pull-request freeze milestone Jun 10, 2026

naala-qcom force-pushed the dt-changes branch from 91d9893 to 2f3186a Compare June 10, 2026 07:20

naala-qcom force-pushed the dt-changes branch from 2f3186a to ae0d27f Compare June 10, 2026 07:26

naala-qcom force-pushed the dt-changes branch from ae0d27f to 8cf2b9d Compare June 10, 2026 11:21

naala-qcom force-pushed the dt-changes branch from 8cf2b9d to 554347d Compare June 10, 2026 11:25

shashim-quic requested changes Jun 10, 2026

View reviewed changes

naala-qcom force-pushed the dt-changes branch from 554347d to d9b2cfa Compare June 10, 2026 15:06

naala-qcom force-pushed the dt-changes branch from d9b2cfa to 1e4ca6b Compare June 11, 2026 05:12

qcomlnxci requested a review from a team June 11, 2026 05:15

naala-qcom force-pushed the dt-changes branch from 1e4ca6b to dd7cc34 Compare June 11, 2026 19:18

naala-qcom requested a review from shashim-quic June 16, 2026 06:32

naala-qcom force-pushed the dt-changes branch from dd7cc34 to 74ef650 Compare June 16, 2026 15:47

This was referenced Jun 17, 2026

shikra: Enable GPU (dt bindings + driver support) #694

Merged

shikra: Add support for GPU and Adreno_SMMU DT #696

Open

naala-qcom force-pushed the dt-changes branch from 74ef650 to 7a35825 Compare June 17, 2026 04:36

Nabige Aala and others added 3 commits June 18, 2026 12:38

PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver

c430732

Enable the ILI7807S 1080x1920 video-mode DSI panel driver as a module, used on the Shikra CQM EVK board. Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>

PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display

d22efc1

Enable the DLC0697 MIPI DSI display panel on the Shikra CQS EVK. Signed-off-by: Nabige Aala <naala@qti.qualcomm.com>

naala-qcom force-pushed the dt-changes branch from 7a35825 to d22efc1 Compare June 18, 2026 07:23

Conversation

naala-qcom commented Jun 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

qlijarvis commented Jun 9, 2026

PR #679 — validate-patch

Final Summary

🔍 Patch Validation

Summary by Patch Type

Commit Message Issues

Authorship & Tags

Patch Categories

Issues

Diff Spot Checks

Verdict

Final Summary

Uh oh!

qlijarvis commented Jun 9, 2026

PR #679 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ dtb-check

❌ check-patch-compliance

Verdict

Uh oh!

naala-qcom commented Jun 10, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 10, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 10, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 10, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 10, 2026

Uh oh!

sgaud-quic commented Jun 10, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 10, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 10, 2026

Uh oh!

shashim-quic left a comment

Choose a reason for hiding this comment

Uh oh!

qswat-orbit-external Bot commented Jun 10, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 12, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 12, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 14, 2026

Uh oh!

qswat-orbit-external Bot commented Jun 15, 2026

Uh oh!

qlijarvis commented Jun 16, 2026

PR #679 — validate-patch

Final Summary

🔍 Patch Validation

Summary by Patch

Patch 01/10: PENDING: arm64: dts: qcom: shikra: Add A704 GPU support

Patch 02/10: PENDING: arm64: dts: qcom: shikra: Add GPU cooling

Patch 03/10: PENDING: arm64: dts: qcom: shikra: Add Adreno SMMU node

Patch 04/10: FROMLIST: dt-bindings: arm-smmu: Document GPU SMMU for Shikra SoC

Patch 05/10: FROMLIST: dt-bindings: display/msm/gpu: Add support for A704 GPU

Patch 06/10: FROMLIST: drm/msm/adreno: Add support for A704 GPU

Patch 07/10: PENDING: arm64: dts: qcom: shikra: Add MDSS display subsystem

Patch 08/10: PENDING: arm64: dts: qcom: shikra-cqm-evk: Enable display and add ili7807s panel

Patch 09/10: PENDING: arm64: defconfig: Enable ILI7807S DSI panel driver

Patch 10/10: PENDING: arm64: dts: qcom: shikra-cqs-evk: Enable display

Overall Issues

Verdict

Final Summary

Uh oh!

qlijarvis commented Jun 16, 2026

PR #679 — checker-log-analyzer

🤖 CI Checker Analysis (checker-log-analyzer)

❌ checkpatch

❌ dtb-check

❌ check-patch-compliance

Verdict

naala-qcom commented Jun 9, 2026 •

edited

Loading