Skip to content

EDAC/qcom: Make irq configuration optional#738

Open
faiyaz-mohammed wants to merge 1 commit into
qualcomm-linux:qcom-nextfrom
faiyaz-mohammed:ddr_ecc
Open

EDAC/qcom: Make irq configuration optional#738
faiyaz-mohammed wants to merge 1 commit into
qualcomm-linux:qcom-nextfrom
faiyaz-mohammed:ddr_ecc

Conversation

@faiyaz-mohammed

Copy link
Copy Markdown

On Shikra, the ECC interrupt configuration—enabling Tag/Data RAM interrupts and setting error thresholds—is already performed by the DSF (DDR System Firmware) before the kernel driver probes. Calling qcom_llcc_core_setup() would redundantly reconfigure these registers.

Set the irq_configured flag in shikra_cfg to skip the redundant kernel-side interrupt enable register writes in qcom_llcc_core_setup().

On Shikra, the ECC interrupt configuration—enabling Tag/Data RAM
interrupts and setting error thresholds—is already performed by the DSF
(DDR System Firmware) before the kernel driver probes. Calling
qcom_llcc_core_setup() would redundantly reconfigure these registers.

Set the irq_configured flag in shikra_cfg to skip the redundant
kernel-side interrupt enable register writes in qcom_llcc_core_setup().

Signed-off-by: Faiyaz Mohammed <faiyazm@qti.qualcomm.com>
@qswat-orbit-external

Copy link
Copy Markdown

Merge Check Failed: No CR Numbers Found

Error: No Change Request numbers were found.

Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests.

@apateriy-qcom

Copy link
Copy Markdown

On Shikra, the ECC interrupt configuration—enabling Tag/Data RAM interrupts and setting error thresholds—is already performed by the DSF (DDR System Firmware) before the kernel driver probes. Calling qcom_llcc_core_setup() would redundantly reconfigure these registers.

Set the irq_configured flag in shikra_cfg to skip the redundant kernel-side interrupt enable register writes in qcom_llcc_core_setup().

add CRs-Fixed: 4576473 in PR summary.

@shashim-quic shashim-quic left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDAC/qcom: Make irq configuration optional

missing prefix , Link: tag

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants