Improve Bazel config files#1063
Draft
mhucka wants to merge 21 commits into
Draft
Conversation
The value is the default, and no longer seems to be necessary.
This now probes the current host's capabilities for AVX and SSE features. For example, using `bazel build --config=avx` will get the right AVX (AVX2, AVX512F, etc.) based on what the host reports it supports.
This provides a way to pass `-march=native` to the build.
With the availability of the `--config=native` option, this can be simplified.
Collaborator
Author
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the Bazel build configuration to centralize and automate SIMD instruction set detection and flag selection across Linux, macOS, and Windows. It introduces a new compiler probing mechanism that removes the dependency on the py-cpuinfo Python package. Feedback identifies several critical issues in the newly added unit tests, including incorrect unpacking of return values and inaccurate expectations for compiler flags. Furthermore, the feature detection heuristic for Windows was noted as incomplete.
Simplify code and fix behavioral problems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
--config=avxand similar flags.