docs(interface): declare TokenSelfTrade in IRaindexV6 and document revert in quote2/takeOrders4/clear3#64
Conversation
…2/takeOrders4/clear3 revert TokenSelfTrade is thrown by the implementation in quote2, takeOrders4, and clear3 when an order's input and output token are identical. It was not declared in the interface at all, so callers had no way to catch it by type. Refs raindex#2671 (item 6 — undocumented TokenSelfTrade revert path in quote2).
|
Warning Review limit reached
Next review available in: 47 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
error TokenSelfTrade()inIRaindexV6— it was thrown by the implementation (quote2,takeOrders4,clear3viacheckTokenSelfTrade) but absent from the interface entirely, leaving callers unable to catch it by type.@devrevert note toquote2,takeOrders4, andclear3documenting the self-trade guard.No logic or bytecode change; interface/NatSpec only.
Refs rainlanguage/raindex#2671 (item 6 — undocumented
TokenSelfTraderevert path inquote2)Test plan