Skip to content

docs(interface): declare TokenSelfTrade in IRaindexV6 and document revert in quote2/takeOrders4/clear3#64

Open
thedavidmeister wants to merge 1 commit into
mainfrom
2026-06-30-issue-2671-token-self-trade-interface
Open

docs(interface): declare TokenSelfTrade in IRaindexV6 and document revert in quote2/takeOrders4/clear3#64
thedavidmeister wants to merge 1 commit into
mainfrom
2026-06-30-issue-2671-token-self-trade-interface

Conversation

@thedavidmeister

Copy link
Copy Markdown
Contributor

Summary

  • Declares error TokenSelfTrade() in IRaindexV6 — it was thrown by the implementation (quote2, takeOrders4, clear3 via checkTokenSelfTrade) but absent from the interface entirely, leaving callers unable to catch it by type.
  • Adds a @dev revert note to quote2, takeOrders4, and clear3 documenting the self-trade guard.

No logic or bytecode change; interface/NatSpec only.

Refs rainlanguage/raindex#2671 (item 6 — undocumented TokenSelfTrade revert path in quote2)

Test plan

  • CI passes (no Solidity logic change)
  • Slither passes

…2/takeOrders4/clear3 revert

TokenSelfTrade is thrown by the implementation in quote2, takeOrders4, and
clear3 when an order's input and output token are identical. It was not
declared in the interface at all, so callers had no way to catch it by type.

Refs raindex#2671 (item 6 — undocumented TokenSelfTrade revert path in quote2).
@thedavidmeister thedavidmeister self-assigned this Jun 30, 2026
@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@thedavidmeister, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 47 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 80ff458d-0b2f-4c5a-8551-3fedd134375a

📥 Commits

Reviewing files that changed from the base of the PR and between 3c67370 and ee79132.

📒 Files selected for processing (1)
  • src/interface/IRaindexV6.sol
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 2026-06-30-issue-2671-token-self-trade-interface

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant