docs(natspec): correct LibOpContext.run/@param: column is low byte, row is second byte#538
docs(natspec): correct LibOpContext.run/@param: column is low byte, row is second byte#538thedavidmeister wants to merge 1 commit into
Conversation
…e, row is second byte
LibSubParse.subParserContext (line 68-69) stores column at low byte 0x23
and row at second byte 0x22. LibOpContext.run/referenceFn said the opposite
('row (low byte) and column (second byte)'), inverting the semantics. The
actual cell read is always correct (encode/decode use the same byte), but
the @param description was misleading.
Refs rainlanguage/raindex#2671 (item 5 — @param column/row inversion).
|
Warning Review limit reached
Next review available in: 45 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Corrects the
@param operandNatSpec inLibOpContext.runandLibOpContext.referenceFn.LibSubParse.subParserContext(the encoder) stores column at offset 0x23 (low byte) and row at offset 0x22 (second byte). The old NatSpec said the opposite — "row (low byte) and column (second byte)" — inverting the semantics in documentation.The actual cell read
state.context[i][j]wherei = low byte, j = second byteis always consistent with the encode side, so no runtime behavior is affected. This is a doc-only fix.Refs rainlanguage/raindex#2671 (item 5 —
@paramcolumn/row inversion inLibOpContext.run/referenceFn)Test plan