Skip to content

fix: replace focus-visible outline with subtle background#808

Merged
rohanchkrabrty merged 1 commit into
mainfrom
worktree-fix-sidebar
May 15, 2026
Merged

fix: replace focus-visible outline with subtle background#808
rohanchkrabrty merged 1 commit into
mainfrom
worktree-fix-sidebar

Conversation

@rohanchkrabrty
Copy link
Copy Markdown
Contributor

Summary

  • Remove the default browser focus-visible outline on Sidebar.Item (.nav-item).
  • Apply --rs-color-background-base-primary-hover (neutral-3) as the focus-visible background — one shade lighter than the active state's neutral-4.
  • Source order keeps the active style winning when an item is both active and focused.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
apsara Ready Ready Preview, Comment May 14, 2026 4:46pm

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 14, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds keyboard focus styling to sidebar navigation items. A new :focus-visible pseudo-class rule for .nav-item removes the default browser focus outline and replaces it with the sidebar's hover background color and primary text color, ensuring keyboard users receive visual focus feedback consistent with the hover state.

Suggested reviewers

  • rsbh
  • paanSinghCoder
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description is directly related to the changeset, providing clear context about removing the outline, applying the new background color, and maintaining style precedence.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The PR title accurately describes the main change: replacing the default focus-visible outline with a subtle background color on sidebar navigation items.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohanchkrabrty rohanchkrabrty changed the title fix(sidebar): replace focus-visible outline with subtle background fix: replace focus-visible outline with subtle background May 14, 2026
@rohanchkrabrty rohanchkrabrty merged commit dc6e8c8 into main May 15, 2026
5 checks passed
@rohanchkrabrty rohanchkrabrty deleted the worktree-fix-sidebar branch May 15, 2026 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants