You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fixes issue where XHTML content elements were parsed out of order, causing concatenated text without proper separation between elements.
Problem
When parsing RSS feeds with XHTML content, elements like <strong> tags and <small> tags were being concatenated without proper separation, resulting in malformed output like:
Solution
Added buildOrderedContent() function in lib/utils.js to preserve element sequence
Integrated ordered XML parser using xml2js preserveChildrenOrder option
Updated both Atom and RSS parsers to use ordered content when available
Added comprehensive test case to verify the fix
Files Changed
lib/utils.js: Added buildOrderedContent() function
lib/parser.js: Added ordered XML parser and integration
test/parser.js: Added test case for XHTML content order preservation
test/input/xhtml-content-order.rss: Test fixture
test/output/xhtml-content-order.json: Expected test output
Testing
All existing tests pass
New test case "should preserve XHTML content order" passes
Content ordering is maintained properly in both Atom and RSS feeds
This comment was posted by an AI agent (OpenHands).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR Fixes #275
Summary
Fixes issue where XHTML content elements were parsed out of order, causing concatenated text without proper separation between elements.
Problem
When parsing RSS feeds with XHTML content, elements like
<strong>tags and<small>tags were being concatenated without proper separation, resulting in malformed output like:Solution
buildOrderedContent()function inlib/utils.jsto preserve element sequencepreserveChildrenOrderoptionFiles Changed
lib/utils.js: AddedbuildOrderedContent()functionlib/parser.js: Added ordered XML parser and integrationtest/parser.js: Added test case for XHTML content order preservationtest/input/xhtml-content-order.rss: Test fixturetest/output/xhtml-content-order.json: Expected test outputTesting