Migrate Utilities and EventEmitter Jest tests to Fantom#57267
Closed
rubennorte wants to merge 3 commits into
Closed
Migrate Utilities and EventEmitter Jest tests to Fantom#57267rubennorte wants to merge 3 commits into
rubennorte wants to merge 3 commits into
Conversation
Summary:
Migrates the pure-logic StyleSheet unit tests from regular Jest (`-test.js`) to Fantom (`-itest.js`), so they run on Hermes inside the real React Native runtime, the same engine that runs this code in production.
Migrated files (all style-processing utilities that run on the client at runtime): `flattenStyle`, `processAspectRatio`, `processBackgroundPosition`, `processBackgroundRepeat`, `processBackgroundSize`, `processFilter`, `processFontVariant`, `processTransform`, `processTransformOrigin`, `setNormalizedColorAlpha`, `splitLayoutProps`.
Notable adaptations:
- `toThrowErrorMatchingSnapshot()` and `toThrowErrorMatchingInlineSnapshot()` are not available in Fantom, so they were replaced with `toThrow('<exact message>')`, preserving the exact error messages that were previously captured in snapshots.
- Removed the now-obsolete file snapshots for `processAspectRatio`, `processTransform`, and `processTransformOrigin`.
- `toMatchInlineSnapshot` (used by `splitLayoutProps`) is supported by Fantom and was kept unchanged.
Changelog: [Internal]
Differential Revision: D108759084
Summary: Migrates the remaining StyleSheet unit tests from regular Jest (`-test.js`) to Fantom (`-itest.js`): `normalizeColor`, `processColor`, `processColorArray`, `processBackgroundImage`, and `StyleSheet`. These run on the React Native client at runtime, so they now run on Hermes in the real runtime. Adaptations (no coverage weakened): - Replaced `jest.spyOn(console, ...)` with manual save/replace/restore of the `console` method (Fantom does not provide `jest.spyOn`), both to assert and to suppress expected output. - Replaced the module-mock delegation check in `normalizeColor` (which relied on `jest.mock`) with a behavioral assertion on the real implementation. - These tests run on the Android runtime under Fantom (Jest defaulted to iOS); platform-specific requires were moved next to their platform branches where needed. Changelog: [Internal] Differential Revision: D108759085
Summary: Migrates 17 unit tests from regular Jest (`-test.js`) to Fantom (`-itest.js`) under `Libraries/Utilities` (and `Libraries/Utilities/differ`) and `Libraries/vendor/emitter`, so this runtime client code is tested on Hermes in the real React Native runtime. Migrated: `binaryToBase64`, `deepFreezeAndThrowOnMutationInDev`, `DeviceInfo`, `Dimensions`, `logError`, `mapWithSeparator`, `PixelRatio`, `Platform`, `SceneTracker`, `stringifySafe`, `useColorScheme`, `useMergeRefs`, `useRefEffect`, `warnOnce`, `differ/deepDiffer`, `differ/matricesDiffer`, and `EventEmitter`. Adaptations (no behavioral coverage weakened): - Replaced `jest.spyOn(console, ...)` with manual save/replace/restore capture of the `console` method. - Replaced hook/component tests that used `react-test-renderer` with Fantom rendering (`createRoot` + `runTask`), reading hook return values via a small probe component and ref identity via `ensureInstance`. - Adapted a few expected values to the real Hermes/Android runtime (e.g. function `toString` output, `useColorScheme` returning null when native Appearance is unavailable). - Replaced node-only `TextEncoder`/`TextDecoder` usage in `binaryToBase64` with explicit byte construction. Two tests intentionally remain on Jest because they cannot be expressed without module mocking / the test-renderer tree API (both unsupported by Fantom): `codegenNativeComponent` (mocks native component registration) and `ReactNativeTestTools` (tests jest helpers built on the `react-test-renderer` instance tree). Changelog: [Internal] Differential Revision: D108759079
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D108759079. |
|
This pull request has been merged in 379f477. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Migrates 17 unit tests from regular Jest (
-test.js) to Fantom (-itest.js) underLibraries/Utilities(andLibraries/Utilities/differ) andLibraries/vendor/emitter, so this runtime client code is tested on Hermes in the real React Native runtime.Migrated:
binaryToBase64,deepFreezeAndThrowOnMutationInDev,DeviceInfo,Dimensions,logError,mapWithSeparator,PixelRatio,Platform,SceneTracker,stringifySafe,useColorScheme,useMergeRefs,useRefEffect,warnOnce,differ/deepDiffer,differ/matricesDiffer, andEventEmitter.Adaptations (no behavioral coverage weakened):
jest.spyOn(console, ...)with manual save/replace/restore capture of theconsolemethod.react-test-rendererwith Fantom rendering (createRoot+runTask), reading hook return values via a small probe component and ref identity viaensureInstance.toStringoutput,useColorSchemereturning null when native Appearance is unavailable).TextEncoder/TextDecoderusage inbinaryToBase64with explicit byte construction.Two tests intentionally remain on Jest because they cannot be expressed without module mocking / the test-renderer tree API (both unsupported by Fantom):
codegenNativeComponent(mocks native component registration) andReactNativeTestTools(tests jest helpers built on thereact-test-rendererinstance tree).Changelog: [Internal]
Differential Revision: D108759079