Fix Android display metrics refresh on density changes#57295
Open
nikhilpakhloo wants to merge 1 commit into
Open
Fix Android display metrics refresh on density changes#57295nikhilpakhloo wants to merge 1 commit into
nikhilpakhloo wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Android display metrics getting stale when a React Native surface moves to a display/window with a different density, such as Samsung DeX, freeform windows, external monitors, or ChromeOS.
DisplayMetricsHolderwas initialized once and could keep using the main display density, while Fabric/root layout could use the current display density. This caused textsp -> pxconversion to use the wrong scale, making text render too large and clip.Changes
DisplayMetricsHolderwhen Android configuration/display metrics change.Changelog:
[ANDROID] [FIXED] - Keep display metrics in sync when Android display density changes
Test Plan
ktfmtFormat.git diff --check.buildCodegenCLI/tarpath handling.