feat: canvas tab groups#9594
Open
nishantmonu51 wants to merge 17 commits into
Open
Conversation
Add inline tab groups to canvas dashboards. A top-level `rows:` entry is
either a plain row or a `tabs:` group; a canvas can interleave free rows with
multiple independent tab groups. Only the active tab's components mount, so
inactive tabs issue no queries. Existing canvases render unchanged.
- Proto/parser/reconciler: `CanvasTabGroup`/`CanvasTab` messages, parser
validation (no items+tabs, no nesting, ≥1 tab, unique group/tab names),
recursive component-name collection, schema + generated docs.
- Frontend: `LayoutBlock`/`TabGroup` state, per-tab grids, prefixed component
paths, query isolation via `{#if}`, per-group `?tabs=` URL state.
- Visual editor: add/rename/delete/reorder tabs (menu + drag), add tab group
from the add menu, convert rows to a tab group, cross-container component
drag, delete-with-unwrap, in/outside add affordances, group boundary.
djbarnwal
reviewed
Jun 23, 2026
Comment on lines
+24
to
+28
| // it so web-common unit tests that pull in canvas-entity can resolve the import graph. | ||
| alias.push({ | ||
| find: "@rilldata/web-admin/client", | ||
| replacement: "/../web-common/tests/web-admin-client.mock.ts", | ||
| }); |
Collaborator
There was a problem hiding this comment.
Ya we need this for the new tests added. It is due the hacky way we get bookmark info in canvas. In explore it is passed from parent vs in canvas where only in admin it is pulled in canvas-entity.
Collaborator
|
Some initial UXQA,
Will take a deeper look at the code before commenting on #9594 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds inline tab groups to canvas dashboards.
rows:entry is either a plain row (items:) or a tab group (tabs:); a canvas can interleave free rows with multiple independent tab groups.CanvasTabGroup/CanvasTabproto messages; parser validation (noitems+tabs, no nesting, ≥1 tab, unique group/tab names); recursive component-name collection; schema + generated docs.LayoutBlock/TabGroupmodel with per-tab grids, prefixed component paths, and per-group?tabs=group:tabURL state (keys percent-encoded so names with:/,round-trip).+menu, convert rows to a tab group, cross-container component drag, delete-with-unwrap, in-tab/below-tab add affordances, and a group boundary treatment.Checklist:
Developed in collaboration with Claude Code