Skip to content

Ability to disable models in Rill completely#9616

Open
k-anshul wants to merge 2 commits into
mainfrom
disable_model_execution
Open

Ability to disable models in Rill completely#9616
k-anshul wants to merge 2 commits into
mainfrom
disable_model_execution

Conversation

@k-anshul

@k-anshul k-anshul commented Jun 26, 2026

Copy link
Copy Markdown
Member

closes https://linear.app/rilldata/issue/ENG-1119/ability-to-pause-and-unpause-reconciler#comment-68e95a7d

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

@k-anshul k-anshul self-assigned this Jun 26, 2026
@nishantmonu51

Copy link
Copy Markdown
Collaborator

to understand the behavior more here - When the model reconcilation is paused, would it still reconcile metrics view and dashboards or get those in error state as the model execution threw error ? I wonder if instead of throwing error, we do a WARN and make the model reconcile no-op and complete with success so that the underlying metrics view reconcile.

I am also if we might be able to use this for cases when a user only wants to make changes to metrics view and not any models ?

@k-anshul

k-anshul commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

When the model reconcilation is paused, would it still reconcile metrics view and dashboards or get those in error state as the model execution threw error ?

Depends:

  1. If the model is non partition model then it will fail.
  2. If the model is partitioned model then only some partitions will fail which does not mark entire model as failed and metrics view will succeed.

I wonder if instead of throwing error, we do a WARN and make the model reconcile no-op and complete with success so that the underlying metrics view reconcile.

That feels like it can have some unintended consequences like model success but no data. If refresh is not set then it will require explicit refresh after unpause.

@nishantmonu51

Copy link
Copy Markdown
Collaborator

is there any other state other than error we can return ? e.g. not_executed ? instead of passing it? so that when its unpaused it executes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants