feat(example): show milliseconds since logger init#407
Open
SAY-5 wants to merge 1 commit into
Open
Conversation
epage
reviewed
May 14, 2026
epage
reviewed
May 14, 2026
Comment on lines
+35
to
+38
| init_logger(); | ||
|
|
||
| log::info!("a log from `MyLogger`"); | ||
| log::warn!("another log, a moment later"); |
Contributor
There was a problem hiding this comment.
Should we have sleeps or something else to help make the elapsed time more obvious?
epage
reviewed
May 14, 2026
| let start = Instant::now(); | ||
| Builder::from_env(env) | ||
| .format(move |buf, record| { | ||
| let elapsed = start.elapsed().as_millis(); |
Contributor
There was a problem hiding this comment.
Should we consolidate this example with custom_format.rs?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an example that captures
Instant::now()and uses it inside the custom format closure to print elapsed milliseconds, matching the approach @vigna confirmed in #355. Closes #355.