Skip to content

Add ParserCore.dll.config and FwUtils.dll.config to rescue patching#920

Closed
jasonleenaylor wants to merge 1 commit into
mainfrom
claude/festive-antonelli-536716
Closed

Add ParserCore.dll.config and FwUtils.dll.config to rescue patching#920
jasonleenaylor wants to merge 1 commit into
mainfrom
claude/festive-antonelli-536716

Conversation

@jasonleenaylor
Copy link
Copy Markdown
Contributor

@jasonleenaylor jasonleenaylor commented Jun 2, 2026

Summary

  • Added ParserCore.dll.config and FwUtils.dll.config to the RescuePatching target in Build/Installer.legacy.targets
  • These config files were removed since the last base installer build; without placeholder entries the patchable installer cannot generate a valid patch

Background

The RescuePatching target writes empty placeholder files for anything that was present in the base build but has since been removed. This lets the patch diffing process succeed even when files disappear between base builds.

Test plan

  • Verify the patchable installer build completes without errors related to missing ParserCore.dll.config or FwUtils.dll.config

🤖 Generated with Claude Code


This change is Reviewable

These config files were removed since the last base installer build.
Without placeholder entries the patchable installer fails to diff them.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jasonleenaylor jasonleenaylor marked this pull request as ready for review June 2, 2026 16:53
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

NUnit Tests

    1 files  ±0      1 suites  ±0   10m 53s ⏱️ -57s
4 210 tests ±0  4 140 ✅ ±0  70 💤 ±0  0 ❌ ±0 
4 219 runs  ±0  4 149 ✅ ±0  70 💤 ±0  0 ❌ ±0 

Results for commit 5481930. ± Comparison against base commit bcbb024.

@johnml1135 johnml1135 requested review from Copilot and johnml1135 June 5, 2026 18:00
@johnml1135 johnml1135 removed their request for review June 5, 2026 18:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@jasonleenaylor jasonleenaylor deleted the claude/festive-antonelli-536716 branch June 6, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants