Skip to content

fix: 모집 인원 미정 표시 처리#577

Merged
yoonc01 merged 1 commit into
mainfrom
fix/nullable-student-capacity-ui
Jun 25, 2026
Merged

fix: 모집 인원 미정 표시 처리#577
yoonc01 merged 1 commit into
mainfrom
fix/nullable-student-capacity-ui

Conversation

@yoonc01

@yoonc01 yoonc01 commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

관련 이슈

  • 서버에서 지원 가능 대학의 studentCapacity가 nullable하게 응답될 수 있도록 변경되었습니다.
  • 기존 프론트 타입은 studentCapacity를 항상 number로 가정하고 있어, 모집 인원이 없는 경우 UI에서 부정확하게 표시될 수 있었습니다.
  • 경희대 2027-1 지원 가능 대학 데이터 중 모집 인원이 아직 미정인 학교가 있어, 프론트에서도 nullable 응답을 처리해야 합니다.

작업 내용

  • 대학 목록/상세 응답 타입의 studentCapacitynumber | null로 변경했습니다.
  • 모집 인원이 없는 경우 모집 인원 미정으로 표시되도록 처리했습니다.
  • 모집 인원 기준 정렬 시 null 값은 뒤로 정렬되도록 처리했습니다.

@yoonc01 yoonc01 self-assigned this Jun 25, 2026
@vercel

vercel Bot commented Jun 25, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Error Error Jun 25, 2026 2:40pm
solid-connection-web Ready Ready Preview, Comment Jun 25, 2026 2:40pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Jun 25, 2026 2:40pm

@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@yoonc01, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 15 minutes and 12 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 254ea929-04b6-42fe-9cfa-a11aeb8f4f91

📥 Commits

Reviewing files that changed from the base of the PR and between 8ee2a03 and 6a05f83.

📒 Files selected for processing (9)
  • apps/university-web/src/apis/universities/api.ts
  • apps/university-web/src/app/university/[homeUniversity]/[id]/_ui/UniversityDetail/index.tsx
  • apps/university-web/src/app/university/[homeUniversity]/[id]/page.tsx
  • apps/university-web/src/components/ui/UniverSityCard/index.tsx
  • apps/university-web/src/types/university.ts
  • apps/web/src/apis/universities/api.ts
  • apps/web/src/app/my/favorite/_ui/FavoriteContent/_hooks/useSortedUniversities.ts
  • apps/web/src/components/ui/UniverSityCard/index.tsx
  • apps/web/src/types/university.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/nullable-student-capacity-ui

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added the web label Jun 25, 2026
@yoonc01 yoonc01 merged commit a1a2241 into main Jun 25, 2026
12 of 13 checks passed
@yoonc01 yoonc01 deleted the fix/nullable-student-capacity-ui branch June 25, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant