macOS: Keep system buttons hidden #228
Open
3unjee wants to merge 1 commit into
Open
Conversation
Collaborator
|
Thanks! |
Collaborator
|
Sorry for the late reply! I've been to hospital last week and have no access to PC/network. And I have some discussions with the other main maintainer, sadly both of us have no ability to review macOS code, so we can't decide what to do with this PR. Maybe you can test this PR in more environments to make sure no regressions are introduced? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures that macOS system buttons stay hidden when the user sets the following:
AppKit restores system button visibility automatically when switching context like full-screen or opening dialogs. So we add an observer on the button 'hidden' state to restore the proper visibility when required.