fail eagerly when missing JavaObject mapping#789
Merged
Conversation
Collaborator
|
This looks good, thank you! |
Contributor
Author
|
Thanks. Regarding the failed |
Collaborator
|
Yes, nightly is broken -- not your fault :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When translating a non-root Java class, missing the
java.lang.Object -> JavaObjectmapping could allow generation to continue and produce invalid Swift (without the required JavaObject inheritance).This now fails eagerly when a Java superclass exists but the JavaObject mapping is unavailable. The regression test clears the mapping while translating
java.lang.Stringas a Swift class and asserts the missingjava.lang.Objecterror.Test:
swift test --filter testMissingJavaObjectMappingFailsEagerlyswift test --filter Java2SwiftTestsswift-format lint --configuration .swift-format Sources/SwiftJavaToolLib/JavaClassTranslator.swift Tests/SwiftJavaToolLibTests/Java2SwiftTests.swiftFixes #195.