ci: add release workflows#959
Open
ovitrif wants to merge 1 commit into
Open
Conversation
ben-kaufman
reviewed
May 22, 2026
ben-kaufman
reviewed
May 22, 2026
jvsena42
reviewed
May 25, 2026
jvsena42
previously approved these changes
May 25, 2026
jvsena42
previously approved these changes
May 25, 2026
This comment was marked as resolved.
This comment was marked as resolved.
14162ef to
4aa5247
Compare
ben-kaufman
reviewed
May 25, 2026
ben-kaufman
reviewed
May 25, 2026
4aa5247 to
13528fa
Compare
ben-kaufman
previously approved these changes
May 25, 2026
Collaborator
Author
piotr-iohk
previously requested changes
May 26, 2026
Collaborator
piotr-iohk
left a comment
There was a problem hiding this comment.
Not clear about the reproducible-release.yml. Also I think that /release command and process should be adjusted such that it takes into account release.yml producing release artifacts. Please see individual comments.
13528fa to
117d56e
Compare
can't signal it was addressed by re-requesting review on the "changes requested" alert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Related: #953
Supersedes: #867 (closed as outdated in favor of #953)
This PR:
Caution
If you already have a private debug Firebase config at
app/google-services.json, move it before checking out this PR or pullingmasterafter this PR merges:app/google-services.jsonis now the tracked placeholder for fresh clones. Keepapp/src/mainnetRelease/google-services.jsonunchanged for release builds.Description
The core change is adding protected manual
releaseandrelease-internalGitHub Actions workflows. Both workflows build signed mainnet release artifacts from protected environment secrets.releasekeeps both APK and AAB outputs for Play/GitHub release handling, whilerelease-internalproduces the mainnet APK signed with the internal keystore. These workflows do not run automatically on pushed tags;/releaseremains the release-process orchestrator until it is deliberately updated to consume workflow-produced artifacts.The reproducibility support adds a manual
Reproducible Releaseworkflow andscripts/reproduce-release.shto buildbundleMainnetRelease, recreate APK splits with bundletool, extractarm64-v8anative libraries, and upload checksum evidence. When a comparison artifact is provided,diffoscopedifferences now fail the workflow while still uploading the generated report.GitHub Actions setup:
releaseandrelease-internalGitHub environments for the protected release workflows.releaseenvironment secrets:MAINNET_RELEASE_GOOGLE_SERVICES_JSON_BASE64,BITKIT_KEYSTORE_BASE64,BITKIT_KEYSTORE_PASSWORD,BITKIT_KEY_ALIAS, andBITKIT_KEY_PASSWORD.release-internalenvironment secrets:MAINNET_RELEASE_GOOGLE_SERVICES_JSON_BASE64,INTERNAL_KEYSTORE_BASE64,INTERNAL_KEYSTORE_PASSWORD,INTERNAL_KEY_ALIAS, andINTERNAL_KEY_PASSWORD.GPR_USERandGPR_TOKENremain optional fallback secrets; the workflows prefer the built-in GitHub Actions token withpackages: read.Remaining upstream work for #953:
/releaseso it can trigger/download thereleaseworkflow artifacts instead of relying on local APK creation.bitkit-core-android/ Rust-native AAR builds reproducible upstream.Cargo.lock, build paths,SOURCE_DATE_EPOCH, path remapping, stripping, and published native.sochecksums.androidx.datastore:datastore-coreandnet.java.dev.jna:jnawith diffoscope evidence.Preview
N/A
QA Notes
Manual Tests
app/src/debug/google-services.json) so one file can override the checked-inapp/google-services.jsonplaceholder without dirtying Git;app/src/mainnetRelease/google-services.jsonremains the release-only path.Automated Checks
bash -n scripts/reproduce-release.sh.github/workflows/release.yml,.github/workflows/release-internal.yml, and.github/workflows/reproducible-release.ymlapp/src/debug/google-services.jsonpath while keeping release secrets atapp/src/mainnetRelease/google-services.jsonbash -nfor the release signature verification shell blocksgit diff --checkgit check-ignore -v app/src/debug/google-services.json app/src/mainnetRelease/google-services.jsonsrc/debug/google-services.jsonresolves before the checked-in rootapp/google-services.jsonplaceholder, whilesrc/mainnetRelease/google-services.jsonremains the release override. The root placeholder intentionally omits the productionto.bitkitclient.go run github.com/rhysd/actionlint/cmd/actionlint@latest .github/workflows/reproducible-release.yml .github/workflows/release.yml .github/workflows/release-internal.yml4aa52470d: lint and detekt passed; build/E2E jobs were skipped while the PR was draft.