Fix #2668: terraphim_lsp Foundation (workspace member, edition 2024, no-op server)#918
Open
AlexMikhalev wants to merge 13 commits into
Open
Conversation
added 13 commits
June 14, 2026 00:03
…#2668 - Remove crates/terraphim_lsp from workspace exclude list - Delete orphaned crates/terraphim_lsp/Cargo.lock - Align crate edition with workspace (2024) - Add minimal dependencies: tower-lsp, tokio, serde_json, terraphim_automata, terraphim_types, terraphim_rolegraph - Add no-op tower-lsp server skeleton and module placeholders - Verify via cargo check, clippy, fmt, and test - Add disciplined research/design/implementation/review artefacts
…hind features - Gate terraphim_agent client VM types and methods behind #[cfg(feature = "firecracker")] - Gate firecracker executor module and hybrid executor delegation by feature - Update /sessions REPL command definitions and handler for sessions feature - Fix hybrid risk assessment test expectation when firecracker is disabled - Gate VM integration tests behind firecracker feature Refs #2675 Refs #2674 Refs #2669
- Add document tracking (did_open/did_change/did_close) to TerraphimLspServer - Implement textDocument/hover using kg_analysis term matches - Implement textDocument/completion with thesaurus term filtering - Implement textDocument/diagnostic reporting unknown terms as warnings - Add completion.rs and diagnostics.rs helper modules - Fix kg_analysis to fall back to NormalizedTerm.value for descriptions - Add integration tests and sample markdown fixture Refs #2670
- Test terraphim_grep with --features code-search in ci-main.yml - Add benchmark compilation check with code-search feature Refs #2676
- Add src/main.rs stdio LSP binary - Register binary in Cargo.toml - Add crate README with usage, architecture, and test commands - Validate binary responds to LSP initialize request Refs #2670
Summarises verification evidence for terraphim_lsp, terraphim_agent, and terraphim_grep including test results, lint status, CLI command validation, and outstanding follow-ups. Refs #2678
…efs #2671 - Add thesaurus field to RlmConfig for term matching during validation - Wire KnowledgeGraphValidator into Firecracker/Docker/Local executors - Implement validate() in all executors using shared validator - Add KG validation to QueryLoop::execute_command with LLM context feedback - Validation failures feed back to LLM for rephrasing instead of error out - Add ValidationEvent hooks module for agent learning/security capture - Add TerraphimRlm::new_with_thesaurus convenience constructor - Add retry_count, message, escalation_required to executor ValidationResult - Add feedback_message() builder for LLM context injection
…efs #2671 - Add auto_configure_llm() with 3-tier provider discovery - Ollama (gemma3:270m local) + OpenRouter (llama-3.2-3b free tier) - RouterBridgeLlmClient with CapabilityFirst strategy - Env var overrides: RLM_MODEL, RLM_OPENROUTER_MODEL, RLM_ROUTER_STRATEGY - OpenRouter API key from 1Password (Terraphim vault, personal account) - rlm_query now returns real LLM responses (was LlmNotConfigured)
…iguration Refs #2671
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores
terraphim_lspas a compilable workspace member.\n\nChanges:\n- Removescrates/terraphim_lspfrom workspaceexcludelist\n- Deletes orphanedcrates/terraphim_lsp/Cargo.lock\n- Aligns crate edition with workspace (2024)\n- Adds minimal dependencies:tower-lsp,tokio,serde_json,terraphim_automata,terraphim_types,terraphim_rolegraph\n- Adds no-optower-lspserver skeleton and module placeholders for Steps 2 and 3\n\nVerification:\n-cargo check -p terraphim_lspPASS\n-cargo check --workspacePASS\n-cargo clippy -p terraphim_lsp --all-targets -- -D warningsPASS\n-cargo fmt --all -- --checkPASS\n-cargo test -p terraphim_lspPASS (1 test)\n\nRefs #2668