🔒 Fix Path Traversal Vulnerability in Disk Storage Service#90
Conversation
This commit fixes a path traversal vulnerability in `AbstractDiskBasedService.java`. When constructing the path to store a file, the `id` string was being directly resolved against `storagePath` without a boundary check or normalization, which could lead to path traversal vulnerabilities if `id` contained sequence characters like `../`. A check was added using `normalize()` and `startsWith()` to ensure the generated `uploadPath` is strictly inside the designated `storagePath`. Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
coverage: 94.852% (-0.07%) from 94.92% — fix/path-traversal-8619812930252771219 into master |
2 participants
🎯 What:
Fixed a path traversal vulnerability in
AbstractDiskBasedService.javawhereidstrings were unsafely resolved against the storage path.By crafting a malicious ID containing directory climbing sequences like
../or absolute paths, attackers could potentially write or read files arbitrarily outside the intended upload directory, which is a significant security risk.🛡️ Solution:
Modified
getPathInStorageDirectory(UploadId id)tonormalize()both the resultinguploadPathand the basestoragePath. It explicitly enforces thatuploadPath.toAbsolutePath()begins withstoragePath.toAbsolutePath().normalize()viastartsWith(), throwing anIllegalArgumentExceptionon validation failure.PR created automatically by Jules for task 8619812930252771219 started by @tomdesair