🛡️ Sentinel: [CRITICAL] Fix insecure deserialization#93
Conversation
* Replace ObjectInputStream with ValidatingObjectInputStream in Utils.java. * Restrict allowed classes during deserialization. * Document findings in .jules/sentinel.md. Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
coverage: 94.893% (-0.03%) from 94.92% — sentinel-insecure-deserialization-fix-4825287769009940094 into master |
2 participants
🚨 Severity: CRITICAL
💡 Vulnerability: Insecure deserialization in
Utils.readSerializablevia rawObjectInputStream.🎯 Impact: Could allow an attacker to execute arbitrary code if they can tamper with the serialized files stored on disk.
🔧 Fix: Replaced
ObjectInputStreamwithValidatingObjectInputStreamfromcommons-ioto restrict deserialization to allowed classes (java.lang.*,java.util.*,me.desair.tus.server.upload.*,me.desair.tus.server.checksum.*).✅ Verification: Ran unit tests to ensure deserialization of valid objects still works.
PR created automatically by Jules for task 4825287769009940094 started by @tomdesair