🛡️ Sentinel: [HIGH] Fix CRLF injection in Content-Disposition header#94
🛡️ Sentinel: [HIGH] Fix CRLF injection in Content-Disposition header#94tomdesair wants to merge 2 commits into
Conversation
This commit sanitizes the `filename` parameter in the `Content-Disposition` header in `DownloadGetRequestHandler.java`. By removing carriage returns (`\r`), line feeds (`\n`), and double quotes (`"`), we prevent HTTP Response Splitting / CRLF Injection vulnerabilities. The URL-encoded `filename*` parameter remains fully capable of handling special characters safely. Also added `DownloadGetRequestHandlerSecurityTest.java` to prevent regression. Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
coverage: 94.881% (-0.04%) from 94.92% — bugfix/fix-crlf-injection-12046639770624871868 into master |
This commit sanitizes the `filename` parameter in the `Content-Disposition` header in `DownloadGetRequestHandler.java`. By removing carriage returns (`\r`), line feeds (`\n`), and double quotes (`"`), we prevent HTTP Response Splitting / CRLF Injection vulnerabilities. The URL-encoded `filename*` parameter remains fully capable of handling special characters safely. Also added `DownloadGetRequestHandlerSecurityTest.java` to prevent regression. Co-authored-by: tomdesair <14034630+tomdesair@users.noreply.github.com>
2 participants
🚨 Severity: HIGH
💡 Vulnerability: CRLF Injection / HTTP Response Splitting in
DownloadGetRequestHandler.javathrough thefilenameparameter of theContent-Dispositionheader.🎯 Impact: An attacker could craft a malicious filename containing carriage returns (
\r), line feeds (\n), and double quotes (") to inject arbitrary HTTP headers in the response.🔧 Fix: Sanitized the
filenameparameter by removing\r,\n, and". The RFC 5987 encoded parameter (filename*=UTF-8''...) remains intact and safely URL-encoded to handle legitimate filenames with special characters.✅ Verification: Added
DownloadGetRequestHandlerSecurityTest.javato verify the fix works as expected.PR created automatically by Jules for task 12046639770624871868 started by @tomdesair