Conversation
What was broken Member stats reused the same narrow-card breakpoint for both the one-column layout and compact mobile typography. When the TCO trip-winner banner made the stats card narrow on desktop, the card switched to noticeably smaller text. Root cause The compact typography rules were tied to the 520px layout breakpoint instead of a narrower phone-width breakpoint. What was changed Moved the compact member-stats typography, icon, and padding container query from 520px to 420px. The stats list can still switch to one column at 520px, but desktop-sized text remains at the side-by-side TCO card width. Any added/updated tests No tests were added because this is a CSS container-query adjustment and the repo has no browser visual test harness for this card. Validated the affected profiles tests, lint, and production build. The full repo non-watch test command was also run and failed in unrelated work, engagements, and wallet suites on existing baseline issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
Member stats reused the same narrow-card breakpoint for both the one-column layout and compact mobile typography. When the TCO trip-winner banner made the stats card narrow on desktop, the card switched to noticeably smaller text.
Root cause
The compact typography rules were tied to the 520px layout breakpoint instead of a narrower phone-width breakpoint.
What was changed
Moved the compact member-stats typography, icon, and padding container query from 520px to 420px. The stats list can still switch to one column at 520px, but desktop-sized text remains at the side-by-side TCO card width.
Any added/updated tests
No tests were added because this is a CSS container-query adjustment and the repo has no browser visual test harness for this card.
Validation