Conversation
What was broken High member ratings near the right edge of the rating distribution chart kept the avatar and rating inline, which could push the numeric rating partly outside the chart. Root cause The marker badge always translated the avatar and rating to the right of the marker, leaving no alternate layout for right-edge positions. What was changed Added a right-edge marker layout that stacks the rating below the avatar when the marker is at least 90% across the chart, keeping the value visible while preserving the existing inline layout elsewhere. Any added/updated tests Added a MemberRatingInfoModal regression test for a 3664 rating that verifies the stacked marker layout is applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
High member ratings near the right edge of the rating distribution chart kept the avatar and rating inline, which could push the numeric rating partly outside the chart.
Root cause
The marker badge always translated the avatar and rating to the right of the marker, leaving no alternate layout for right-edge positions.
What was changed
Added a right-edge marker layout that stacks the rating below the avatar when the marker is at least 90% across the chart, keeping the value visible while preserving the existing inline layout elsewhere.
Any added/updated tests
Added a MemberRatingInfoModal regression test for a 3664 rating that verifies the stacked marker layout is applied.
Validation: