Skip to content

PM-5402: Stack high rating marker label#1968

Merged
jmgasper merged 1 commit into
devfrom
PM-5402
Jun 19, 2026
Merged

PM-5402: Stack high rating marker label#1968
jmgasper merged 1 commit into
devfrom
PM-5402

Conversation

@jmgasper

Copy link
Copy Markdown
Collaborator

What was broken
High member ratings near the right edge of the rating distribution chart kept the avatar and rating inline, which could push the numeric rating partly outside the chart.

Root cause
The marker badge always translated the avatar and rating to the right of the marker, leaving no alternate layout for right-edge positions.

What was changed
Added a right-edge marker layout that stacks the rating below the avatar when the marker is at least 90% across the chart, keeping the value visible while preserving the existing inline layout elsewhere.

Any added/updated tests
Added a MemberRatingInfoModal regression test for a 3664 rating that verifies the stacked marker layout is applied.

Validation:

  • Passed: yarn lint
  • Passed: yarn run build (completed with existing CRA build warnings)
  • Passed: yarn test:no-watch --runTestsByPath src/apps/profiles/src/member-profile/about-me/MemberRatingCard/MemberRatingInfoModal/MemberRatingInfoModal.spec.tsx
  • Not passed: yarn test:no-watch and yarn test:no-watch --runInBand currently fail in unrelated work/wallet suites on dev.

What was broken
High member ratings near the right edge of the rating distribution chart kept the avatar and rating inline, which could push the numeric rating partly outside the chart.

Root cause
The marker badge always translated the avatar and rating to the right of the marker, leaving no alternate layout for right-edge positions.

What was changed
Added a right-edge marker layout that stacks the rating below the avatar when the marker is at least 90% across the chart, keeping the value visible while preserving the existing inline layout elsewhere.

Any added/updated tests
Added a MemberRatingInfoModal regression test for a 3664 rating that verifies the stacked marker layout is applied.
@jmgasper jmgasper requested a review from kkartunov as a code owner June 18, 2026 23:43
@jmgasper jmgasper merged commit 23151c5 into dev Jun 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant