Conversation
What was broken The profile Experience and Education and Certifications cards had a larger vertical gap than the updated design. Root cause The Experience/Education wrapper added a 40px grid gap on top of the existing section card margin. What was changed Removed the extra grid gap from the profile Experience/Education wrapper so the stack relies on the standard section spacing. Any added/updated tests No tests were added because this is a CSS-only spacing change. Ran the existing profile member tests, lint, and build. The full non-watch test suite was also run and currently fails in unrelated wallet-admin and work specs outside this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The profile Experience and Education and Certifications cards had a larger vertical gap than the updated design.
Root cause
The Experience/Education wrapper added a 40px grid gap on top of the existing section card margin.
What was changed
Removed the extra grid gap from the profile Experience/Education wrapper so the stack relies on the standard section spacing.
Any added/updated tests
No tests were added because this is a CSS-only spacing change.
Validation run: