Conversation
What was broken The previous PM-5401 fix kept the member stats typography readable for trip-winner layouts, but QA reported that the chevron on the right side of each stats row still did not align consistently. Root cause The right-side track details group had a fixed minimum width, but its contents were left-aligned inside that space. Rows without winner or rating icons left unused space after the chevron, so the chevron landed farther left than rows with icons or wider values. What was changed Right-aligned the contents of the track details group so each row's chevron sits on the same right edge while preserving the existing row structure and spacing. Any added/updated tests Updated the MemberStatsBlock SCSS test to assert that track details are right-aligned for consistent chevron placement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was broken
The previous PM-5401 fix kept member stats text readable in the trip-winner layout, but QA reported that the right-side chevrons still did not align consistently across rows.
Root cause
The track details area had a fixed minimum width, but its internal flex contents were left-aligned. Rows with no winner or rating icon could leave unused space after the chevron, while rows with icons or wider values pushed the chevron farther right.
What was changed
Right-aligned the track details contents so every stats-row chevron sits on the same right edge while preserving the existing card markup, spacing, and typography behavior from the previous fix.
Any added/updated tests
Updated the MemberStatsBlock SCSS test to assert that track details use right alignment for consistent chevron placement.
Validation