ci(forge): fix failing workflow#387
Open
sambacha wants to merge 1 commit into
Open
Conversation
The previous commit saw a CI failure due to not having `--tolerance` specified. I took the difference and rounded up (~2.64% difference in gas snapshot to the value of 3). Also updated the foundry tool chain to the appropriate repo, and updated checkout to use v3.
Owner
|
thanks! but what happened to having a deterministic seed? |
Contributor
Author
You want to create a secondary check with tolerance if the original check fails then? |
Owner
|
hm? forge used to use a deterministic random seed such that re-running would always give the same result and we wouldn't need tolerance at all |
Contributor
Author
https://book.getfoundry.sh/reference/config/testing?highlight=seed#seed
I think this changed with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous commit saw a CI failure due to not having
--tolerancespecified. I took the difference and rounded up (~2.64% difference in gas snapshot to the value of 3).Also updated the foundry tool chain to the appropriate repo, and updated checkout to use v3.
Description
Describe the changes made in your pull request here.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?npm run lint?forge test?Pull requests with an incomplete checklist will be thrown out.