fix(event): back-pressure realtime event loading instead of dropping#6818
Closed
xxo1shine wants to merge 1 commit into
Closed
fix(event): back-pressure realtime event loading instead of dropping#6818xxo1shine wants to merge 1 commit into
xxo1shine wants to merge 1 commit into
Conversation
halibobo1205
approved these changes
Jun 3, 2026
When the realtime event queue was full (maxEventSize), RealtimeEventService.add silently dropped a whole block's realtime events while the solid path still delivered them from cache, causing realtime subscribers to miss events with no way to recover. - RealtimeEventService: add isBusy() (queue.size() >= maxEventSize) and remove the silent drop in add(); just offer to the queue. - BlockEventLoad: gate load() on realtimeEventService.isBusy() so loading pauses (non-blocking, outside the manager lock) when the realtime queue is full, instead of dropping events. - RealtimeEventServiceTest: cover isBusy() for both the not-busy and busy cases. This keeps the realtime queue bounded (no OOM) and does not block block processing; loading resumes and re-derives events from db once the queue drains, so no events are lost.
xxo1shine
force-pushed
the
fix/realtime-event-backpressure
branch
from
2213edd to
b4e01f0
Compare
halibobo1205
added
the
topic:event subscribe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When the realtime event queue was full (maxEventSize), RealtimeEventService.add silently dropped a whole block's realtime events while the solid path still delivered them from cache, causing realtime subscribers to miss events with no way to recover.
This keeps the realtime queue bounded (no OOM) and does not block block processing; loading resumes and re-derives events from db once the queue drains, so no events are lost.
Why are these changes required?
This PR has been tested by:
Follow up
Extra details