Skip to content

Fix input variable for inboard blanket type in PROCESS input file#4300

Merged
je-cook merged 1 commit into
mainfrom
fix_inboard_blkt_enum
Jun 8, 2026
Merged

Fix input variable for inboard blanket type in PROCESS input file#4300
je-cook merged 1 commit into
mainfrom
fix_inboard_blkt_enum

Conversation

@chris-ashe
Copy link
Copy Markdown
Collaborator

Description

Checklist

I confirm that I have completed the following checks:

  • My changes follow the PROCESS style guide
  • I have justified any large differences in the regression tests caused by this pull request in the comments.
  • I have added new tests where appropriate for the changes I have made.
  • If I have had to change any existing unit or integration tests, I have justified this change in the pull request comments.
  • If I have made documentation changes, I have checked they render correctly.
  • I have added documentation for my change, if appropriate.

Copilot AI review requested due to automatic review settings June 8, 2026 09:14
@chris-ashe chris-ashe requested a review from a team as a code owner June 8, 2026 09:14
@chris-ashe chris-ashe added the Bug Something isnt working label Jun 8, 2026
@chris-ashe chris-ashe requested a review from je-cook June 8, 2026 09:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the input-parser module mapping for i_blkt_inboard so that values provided in IN.DAT are applied to the build data structure (where i_blkt_inboard is actually defined/used), rather than being routed to fwbs.

Changes:

  • Update process/core/input.py so i_blkt_inboard is parsed into the build module instead of fwbs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread process/core/input.py
Comment on lines 956 to 959
"i_bldgs_size": InputVariable("buildings", int, choices=[0, 1]),
"i_bldgs_v": InputVariable("buildings", int, choices=[0, 1]),
"i_blkt_inboard": InputVariable("fwbs", int, choices=[0, 1]),
"i_blkt_inboard": InputVariable("build", int, choices=[0, 1]),
"i_bootstrap_current": InputVariable("physics", int, range=(0, 13)),
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.76%. Comparing base (d86c108) to head (7a4c330).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4300      +/-   ##
==========================================
+ Coverage   48.69%   48.76%   +0.06%     
==========================================
  Files         151      151              
  Lines       29290    29328      +38     
==========================================
+ Hits        14263    14301      +38     
  Misses      15027    15027              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@je-cook je-cook merged commit 41c9761 into main Jun 8, 2026
11 of 12 checks passed
@je-cook je-cook self-assigned this Jun 8, 2026
@je-cook je-cook deleted the fix_inboard_blkt_enum branch June 8, 2026 09:32
@je-cook je-cook added the Data structure Issues related to the data structure label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isnt working Data structure Issues related to the data structure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants