Conversation
phndiaye
requested review from
Elodie-DeMatteis-Upf,
aprentout and
nathalieArnoux
and removed request for
a team
phndiaye
commented
Jun 23, 2026
Comment on lines
-81
to
-92
| // eslint-disable-next-line ember/no-deeply-nested-dependent-keys-with-each | ||
| appliedFilters: computed('columns.@each.filters.[]', function () { | ||
| return this.columns | ||
| .map((column) => { | ||
| if (!isEmpty(column.filters)) { | ||
| let _c = {}; | ||
| _c[column.key] = column.filters; | ||
| return _c; | ||
| } | ||
| }) | ||
| .compact(); | ||
| }), |
Member
Author
There was a problem hiding this comment.
phndiaye
commented
Jun 23, 2026
| "remove-pre-push-hook": "rm -rf ./.git/hooks/pre-push" | ||
| }, | ||
| "dependencies": { | ||
| "@ember/string": "^4.0.1", |
Member
Author
There was a problem hiding this comment.
Was used in the codebase without being declared a dependency. Ember 4.12 is less forgiving about it
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Make the compatibility checks running weekly until now a default part of the CI alongside the current test suite checks.
The idea is that for every committed change, we will now run the test suite against both ember-3.28 (current) and ember-4.12 (next) to ensure nobody accidentally introduce deprecated code.
What are the observable changes?
🧑💻 Developer Heads Up
⚡ Since we are using Ember Octane now:
Useful Resource : Ember Octane vs Classic Cheat Sheet
Good PR checklist