Sprint 1: Test safety net for source code work#9
Merged
Conversation
Falsification campaign (15 claims, 4 layers): - Layer 1 (understanding): 1 survived, 2 falsified (CIC-code drift) - Layer 2 (correctness): 4 survived (algorithm verified) - Layer 3 (test sufficiency): 2 contested, 3 falsified (regression/integration/E2E gaps) - Layer 4 (drift detection): 1 survived, 2 contested 11 falsification test stub files document every gap found. Risk register updated: C-12 Tier 1→2, Cluster F (CIC drift) added, Clusters A/C/D tagged contingent on ADR-011. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
7 tests verifying that enrich_dataframe_with_pg_info output matches the manager's filter_cols: all 9 columns present, no nulls for valid GIDs, correct types (numeric admin codes, float coordinates, valid ISO codes), row count preserved, and enriched output passes validation. Closes #4 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
test_enrichment_adds_expected_columns now checks all 9 metadata columns (was 5). Added: pg_xcoord, pg_ycoord, admin1_gaul0_code, admin1_gaul0_name. A rename or removal of any column now fails a test. Closes #5 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ea guard 8 regression tests protecting fixes applied during audit session: - make_valid(): 3 tests (invalid country/admin geometry fixed, fixture guard) - Warning suppression: 2 tests (no global ignore, UserWarning visible) - Zero-area guard: 3 tests (country/admin1/admin2 return None with WARNING) Removing any fix causes at least one test to fail. Closes #6 Closes #7 Closes #8 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Total: 88 passing tests (was 73). Lint clean. No source code modified.
Test plan
pytest tests/test_mapping.py tests/test_validation.py tests/test_integration.py tests/test_regression.py— 88 passedruff check .— All checks passed🤖 Generated with Claude Code