Skip to content

Added link to image resizing options#160

Merged
LukeTowers merged 1 commit into
wintercms:developfrom
WebVPF:patch-1
Oct 10, 2023
Merged

Added link to image resizing options#160
LukeTowers merged 1 commit into
wintercms:developfrom
WebVPF:patch-1

Conversation

@WebVPF

@WebVPF WebVPF commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

@LukeTowers

Copy link
Copy Markdown
Member

@mjauvin are you able to fix the linting errors or have they already been fixed on the develop branch?

@mjauvin

mjauvin commented Oct 2, 2023

Copy link
Copy Markdown
Member

@LukeTowers from what I can see in the code, they have been fixed in develop. Furthermore, my last PR to the docs(#159) passed without those warnings.

@mjauvin

mjauvin commented Oct 2, 2023

Copy link
Copy Markdown
Member

@WebVPF for future PRs to the docs, submit against the develop branch.

@WebVPF

WebVPF commented Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

@mjauvin I proceeded to edit from the link on the documentation page

2023-10-02_161416

@damsfx

damsfx commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

@LukeTowers @mjauvin there's a strange behavior with the documentation site.

The link above have an anchor to file-upload (https://wintercms.com/docs/v1.2/docs/backend/forms#file-upload), but I'm redirected to the icon-picker section (https://wintercms.com/docs/v1.2/docs/backend/forms#icon-picker).

Did one of you guys are in concern with it too ?

@mjauvin

mjauvin commented Oct 2, 2023

Copy link
Copy Markdown
Member

@WebVPF right, ok. @bennothommo is that what we want or should we link to the develop branch ?

@mjauvin

mjauvin commented Oct 2, 2023

Copy link
Copy Markdown
Member

@LukeTowers @mjauvin there's a strange behavior with the documentation site.

The link above have an anchor to file-upload (https://wintercms.com/docs/v1.2/docs/backend/forms#file-upload), but I'm redirected to the icon-picker section (https://wintercms.com/docs/v1.2/docs/backend/forms#icon-picker).

Did one of you guys are in concern with it too ?

Yeah, I've been noticing this as well. There's some magic happening while scrolling (this updates the anchor in the browser URL) and I think this is creating problems when first accessing the full URL that includes the anchor.

@bennothommo any idea ?

@bennothommo

Copy link
Copy Markdown
Member

@WebVPF right, ok. @bennothommo is that what we want or should we link to the develop branch ?

@mjauvin the intention was for the docs versions to match the Winter versions, so if the docs are for a fix/feature in the develop branch, it should be added to the develop branch of the docs. If it's to fix up an issue with the docs for a fix/feature already present in Winter's 1.2 branch, then it should be made to the 1.2 branch of the docs too.

@bennothommo

bennothommo commented Oct 3, 2023

Copy link
Copy Markdown
Member

Yeah, I've been noticing this as well. There's some magic happening while scrolling (this updates the anchor in the browser URL) and I think this is creating problems when first accessing the full URL that includes the anchor.

@bennothommo any idea ?

Yeah, I'm aware of that issue. I'll try and fix it today.

@LukeTowers

Copy link
Copy Markdown
Member

@bennothommo were you able to fix the issue?

@LukeTowers LukeTowers changed the base branch from 1.2 to develop October 10, 2023 14:47
@LukeTowers LukeTowers merged commit 957ebce into wintercms:develop Oct 10, 2023
@WebVPF WebVPF deleted the patch-1 branch October 10, 2023 14:50
@bennothommo

Copy link
Copy Markdown
Member

@LukeTowers I have fixed the issue locally, but it relies on the PR to Winter to use the external Snowboard library, as the Nabu theme uses a custom app/Snowboard build.

@LukeTowers

Copy link
Copy Markdown
Member

Can you ping me in whatever PRs need review for that again @bennothommo?

@bennothommo

Copy link
Copy Markdown
Member

@LukeTowers this one is the main one: wintercms/winter#980

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants