Support pre 1.24 patches#1193
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1902cfcc29
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (buildConfig.isPre124()) { | ||
| runArgs.setLegacyJassTypeChecks(true); |
There was a problem hiding this comment.
For pre-1.24 builds this only sets the MapRequest field, but the actual build path later calls compileScript(..., compileArgs, ...), constructs a fresh new RunArgs(compileArgs) and passes that to compileMap, so the compiler/PJass checks do not see legacyJassTypeChecks. In BuildMap/CliBuildMap with wc3Patch below 1.24, the stock common.j/blizzard.j return mismatches can still fail during the real compile (and PJass may still run); the flag needs to be carried into the RunArgs used by compileScript/compileMap rather than only this field.
Useful? React with 👍 / 👎.
1 participant
No description provided.