chore: prepare package for npm publish#72
Conversation
- Remove private:true so npm publish is unblocked - Move tsx to dependencies (runtime dep: bin re-execs under tsx) - Add postinstall script to build vendored pi workspace packages - Update README quickstart to npm install -g as primary install path - Update Install & distribution section to reflect published state Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 33 minutes and 45 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6bfd06e3de
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "url": "https://github.com/2witstudios/pagespace-cli/issues" | ||
| }, | ||
| "scripts": { | ||
| "postinstall": "npm run build", |
There was a problem hiding this comment.
On the documented npm install -g pagespace-cli path, this lifecycle script runs in the published package (checked npm install --help: global install is supported and scripts are only skipped with --ignore-scripts). The packed files omit tsconfig.base.json, but every workspace tsconfig.build.json extends ../../tsconfig.base.json, and the tsgo compiler is only in root devDependencies, which consumers do not get. This makes the new postinstall fail before the package finishes installing; ship prebuilt dist output or include the required build inputs/tools for runtime installs.
Useful? React with 👍 / 👎.
| "dependencies": { | ||
| "tsx": "^4.19.2" | ||
| }, |
There was a problem hiding this comment.
After installing the published tarball, npm leaves the included workspace folders under packages/ and does not link them into this package's node_modules (verified with a minimal packed workspace package); however bin/pagespace.mjs launches ../node_modules/@earendil-works/pi-coding-agent/dist/cli.js. This dependencies block installs only tsx, so even if the build step is bypassed or fixed, the pagespace bin exits with MODULE_NOT_FOUND for the pi CLI. Add the pi package as a real runtime dependency or launch from the vendored packages/pi-coding-agent path.
Useful? React with 👍 / 👎.
1 participant
Summary
"private": true— unblocksnpm publishtsxfrom devDependencies → dependencies (runtime dep: bin re-execs under tsx; not available on global install otherwise)"postinstall": "npm run build"— builds vendored pi workspace packages afternpm install -gnpm install -g pagespace-clias the primary path; git clone flow moved to contributors sectionTest plan
npm packand inspect tarball contents include expected filesnpm publish(user will run)npm install -g pagespace-clion a clean machine runs onboarding correctly🤖 Generated with Claude Code