-
Notifications
You must be signed in to change notification settings - Fork 0
chore: prepare package for npm publish #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| { | ||
| "name": "pagespace-cli", | ||
| "version": "0.0.1", | ||
| "private": true, | ||
| "type": "module", | ||
| "workspaces": [ | ||
| "packages/*" | ||
|
|
@@ -21,6 +20,7 @@ | |
| "url": "https://github.com/2witstudios/pagespace-cli/issues" | ||
| }, | ||
| "scripts": { | ||
| "postinstall": "npm run build", | ||
| "build": "npm run build -w packages/pi-tui -w packages/pi-ai -w packages/pi-agent-core -w packages/pi-coding-agent", | ||
| "typecheck": "tsc --noEmit -p .", | ||
| "lint": "biome check src extensions test", | ||
|
|
@@ -30,13 +30,15 @@ | |
| "check": "npm run typecheck && npm run lint && npm run test", | ||
| "prepare": "husky" | ||
| }, | ||
| "dependencies": { | ||
| "tsx": "^4.19.2" | ||
| }, | ||
|
Comment on lines
+33
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
After installing the published tarball, npm leaves the included workspace folders under Useful? React with 👍 / 👎. |
||
| "devDependencies": { | ||
| "@biomejs/biome": "^1.9.4", | ||
| "@earendil-works/pi-ai": "workspace:*", | ||
| "@earendil-works/pi-coding-agent": "workspace:*", | ||
| "@typescript/native-preview": "7.0.0-dev.20260120.1", | ||
| "husky": "^9.1.7", | ||
| "tsx": "^4.19.2", | ||
| "typebox": "^1.1.39", | ||
| "typescript": "^5.9.3" | ||
| }, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On the documented
npm install -g pagespace-clipath, this lifecycle script runs in the published package (checkednpm install --help: global install is supported and scripts are only skipped with--ignore-scripts). The packed files omittsconfig.base.json, but every workspacetsconfig.build.jsonextends../../tsconfig.base.json, and thetsgocompiler is only in rootdevDependencies, which consumers do not get. This makes the new postinstall fail before the package finishes installing; ship prebuiltdistoutput or include the required build inputs/tools for runtime installs.Useful? React with 👍 / 👎.