Fix download timeout: use 10min HttpClient and ResponseHeadersRead#10
Open
bryanwong1 wants to merge 1 commit into
Open
Fix download timeout: use 10min HttpClient and ResponseHeadersRead#10bryanwong1 wants to merge 1 commit into
bryanwong1 wants to merge 1 commit into
Conversation
bryanwong1
force-pushed
the
fix/download-timeout-httpclient
branch
from
8e300a6 to
adede8f
Compare
There was a problem hiding this comment.
Pull request overview
Adjusts package download behavior in Program.cs to prevent large/slow downloads from failing due to the default HttpClient timeout, by streaming the response body and increasing the configured timeout.
Changes:
- Set a 10-minute
HttpClient.Timeoutfor package downloads. - Use
HttpCompletionOption.ResponseHeadersReadto begin streaming the download to disk as soon as headers arrive.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+984
to
+988
| // Use a 10-minute timeout so large MSIs (e.g. CimianTools ARM64) don't hit | ||
| // the 100-second HttpClient default on slow links. ResponseHeadersRead lets | ||
| // GetAsync return as soon as headers arrive; the body streams via CopyToAsync | ||
| // which is not subject to HttpClient.Timeout. | ||
| using var httpClient = new HttpClient { Timeout = TimeSpan.FromMinutes(10) }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.