Refactor collections nodes#562
Merged
arcondello merged 1 commit intoJun 12, 2026
Merged
Conversation
No functional change, just moving things around and minor renaming.
wbernoudy
reviewed
Jun 9, 2026
| return data_ptr<DisjointBitSetsNodeData_>(state)->get_containing_set_index(element); | ||
| } | ||
|
|
||
| DisjointBitSetNode::DisjointBitSetNode(DisjointBitSetsNode* disjoint_bit_sets_node) : |
Member
There was a problem hiding this comment.
Should this be at the top of the DisjointBitSetNode section?
Member
Author
There was a problem hiding this comment.
yes it should, good catch.
Member
Author
There was a problem hiding this comment.
Oh wait, it is. DisjointBitSetsNode (plural) vs DisjointBitSetNode (singular).
Though I suppose we should change the order of nodes for the singular to be above the plural in both cases. Edit: I think I'll leave it as-is. While they are out of lexicographic order, this way we don't need to do a forward declaration and IMO this is an example where the exception is helpful rather than harmful. Also also, hopefully these nodes are going away.
Member
Author
|
@wbernoudy tells me he approves |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No functional changes.
Refactors to our
decisioncollections (edit, de-scoping, can make another PR for other decisions) nodes to bring them more in line with our current standards (e.g., #399, #398, alphabetizing methods, better use of private attributes, etc).AI Generation Disclosure
No AI used. Though honestly it probably would have been useful.