Skip to content

test: Move conversation ID tests to their own file#6699

Merged
sentrivana merged 2 commits into
masterfrom
ivana/move-conversation-id-tests
Jun 30, 2026
Merged

test: Move conversation ID tests to their own file#6699
sentrivana merged 2 commits into
masterfrom
ivana/move-conversation-id-tests

Conversation

@sentrivana

Copy link
Copy Markdown
Contributor

Description

For whatever reason, this collection of conversation ID tests was hidden away in test_misc.py. Move them to their own file.

Issues

Reminders

@sentrivana sentrivana requested a review from a team as a code owner June 30, 2026 14:08

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 69b90e6. Configure here.

Comment thread tests/tracing/test_conversation_id.py
Comment thread tests/tracing/test_conversation_id.py
@sentrivana sentrivana enabled auto-merge (squash) June 30, 2026 14:13
@sentrivana sentrivana merged commit c3746b2 into master Jun 30, 2026
146 checks passed
@sentrivana sentrivana deleted the ivana/move-conversation-id-tests branch June 30, 2026 14:22
@github-actions

Copy link
Copy Markdown
Contributor

Codecov Results 📊

89982 passed | ⏭️ 6288 skipped | Total: 96270 | Pass Rate: 93.47% | Execution Time: 316m 18s

📊 Comparison with Base Branch

Metric Change
Total Tests
Passed Tests
Failed Tests
Skipped Tests

✨ No test changes detected

All tests are passing successfully.

✅ Patch coverage is 100.00%. Project has 2435 uncovered lines.
✅ Project coverage is 89.77%. Comparing base (base) to head (head).

Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.77%    89.77%        —%
==========================================
  Files          192       192         —
  Lines        23809     23809         —
  Branches      8218      8218         —
==========================================
+ Hits         21374     21374         —
- Misses        2435      2435         —
- Partials      1347      1347         —

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants