-
Notifications
You must be signed in to change notification settings - Fork 635
test: Move conversation ID tests to their own file #6699
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+185
−184
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,185 @@ | ||
| import pytest | ||
|
|
||
| import sentry_sdk | ||
| from sentry_sdk import start_span | ||
|
|
||
|
|
||
| def test_conversation_id_propagates_to_span_with_gen_ai_operation_name( | ||
| sentry_init, capture_events | ||
| ): | ||
|
sentry[bot] marked this conversation as resolved.
|
||
| """Span with gen_ai.operation.name data should get conversation_id.""" | ||
| sentry_init(traces_sample_rate=1.0) | ||
| events = capture_events() | ||
|
|
||
| scope = sentry_sdk.get_current_scope() | ||
| scope.set_conversation_id("conv-op-name-test") | ||
|
|
||
| with sentry_sdk.start_transaction(name="test-tx"): | ||
| with start_span(op="http.client") as span: | ||
| span.set_data("gen_ai.operation.name", "chat") | ||
|
|
||
| (event,) = events | ||
| span_data = event["spans"][0]["data"] | ||
| assert span_data.get("gen_ai.conversation.id") == "conv-op-name-test" | ||
|
|
||
|
|
||
| def test_conversation_id_propagates_to_span_with_ai_op(sentry_init, capture_events): | ||
| """Span with ai.* op should get conversation_id.""" | ||
| sentry_init(traces_sample_rate=1.0) | ||
| events = capture_events() | ||
|
|
||
| scope = sentry_sdk.get_current_scope() | ||
| scope.set_conversation_id("conv-ai-op-test") | ||
|
|
||
| with sentry_sdk.start_transaction(name="test-tx"): | ||
| with start_span(op="ai.chat.completions"): | ||
| pass | ||
|
|
||
| (event,) = events | ||
| span_data = event["spans"][0]["data"] | ||
| assert span_data.get("gen_ai.conversation.id") == "conv-ai-op-test" | ||
|
|
||
|
|
||
| @pytest.mark.parametrize("stream_gen_ai_spans", [True, False]) | ||
| def test_conversation_id_propagates_to_span_with_gen_ai_op( | ||
| sentry_init, capture_events, capture_items, stream_gen_ai_spans | ||
| ): | ||
| """Span with gen_ai.* op should get conversation_id.""" | ||
| sentry_init( | ||
| traces_sample_rate=1.0, | ||
| stream_gen_ai_spans=stream_gen_ai_spans, | ||
| ) | ||
|
|
||
| if stream_gen_ai_spans: | ||
| items = capture_items("span") | ||
|
|
||
| scope = sentry_sdk.get_current_scope() | ||
| scope.set_conversation_id("conv-gen-ai-op-test") | ||
|
|
||
| with sentry_sdk.start_transaction(name="test-tx"): | ||
| with start_span(op="gen_ai.invoke_agent"): | ||
| pass | ||
|
|
||
| spans = [item.payload for item in items if item.type == "span"] | ||
| span_data = spans[0]["attributes"] | ||
| else: | ||
| events = capture_events() | ||
|
|
||
| scope = sentry_sdk.get_current_scope() | ||
| scope.set_conversation_id("conv-gen-ai-op-test") | ||
|
|
||
| with sentry_sdk.start_transaction(name="test-tx"): | ||
| with start_span(op="gen_ai.invoke_agent"): | ||
| pass | ||
|
|
||
| (event,) = events | ||
| span_data = event["spans"][0]["data"] | ||
|
|
||
| assert span_data.get("gen_ai.conversation.id") == "conv-gen-ai-op-test" | ||
|
|
||
|
|
||
| def test_conversation_id_not_propagated_to_non_ai_span(sentry_init, capture_events): | ||
| """Non-AI span should NOT get conversation_id.""" | ||
| sentry_init(traces_sample_rate=1.0) | ||
| events = capture_events() | ||
|
|
||
| scope = sentry_sdk.get_current_scope() | ||
| scope.set_conversation_id("conv-should-not-appear") | ||
|
|
||
| with sentry_sdk.start_transaction(name="test-tx"): | ||
| with start_span(op="http.client") as span: | ||
| span.set_data("some.other.data", "value") | ||
|
|
||
| (event,) = events | ||
| span_data = event["spans"][0]["data"] | ||
| assert "gen_ai.conversation.id" not in span_data | ||
|
|
||
|
|
||
| def test_conversation_id_not_propagated_when_not_set(sentry_init, capture_events): | ||
| """AI span should not have conversation_id if not set on scope.""" | ||
| sentry_init(traces_sample_rate=1.0) | ||
| events = capture_events() | ||
|
|
||
| # Ensure no conversation_id is set | ||
| scope = sentry_sdk.get_current_scope() | ||
| scope.remove_conversation_id() | ||
|
|
||
| with sentry_sdk.start_transaction(name="test-tx"): | ||
| with start_span(op="ai.chat.completions"): | ||
| pass | ||
|
|
||
| (event,) = events | ||
| span_data = event["spans"][0]["data"] | ||
| assert "gen_ai.conversation.id" not in span_data | ||
|
|
||
|
|
||
| def test_conversation_id_not_propagated_to_span_without_op(sentry_init, capture_events): | ||
| """Span without op and without gen_ai.operation.name should NOT get conversation_id.""" | ||
| sentry_init(traces_sample_rate=1.0) | ||
| events = capture_events() | ||
|
|
||
| scope = sentry_sdk.get_current_scope() | ||
| scope.set_conversation_id("conv-no-op-test") | ||
|
|
||
| with sentry_sdk.start_transaction(name="test-tx"): | ||
| with start_span(name="unnamed-span") as span: | ||
| span.set_data("regular.data", "value") | ||
|
|
||
| (event,) = events | ||
| span_data = event["spans"][0]["data"] | ||
| assert "gen_ai.conversation.id" not in span_data | ||
|
|
||
|
|
||
| def test_conversation_id_propagates_with_gen_ai_operation_name_no_op( | ||
| sentry_init, capture_events | ||
| ): | ||
| """Span with gen_ai.operation.name but no op should still get conversation_id.""" | ||
| sentry_init(traces_sample_rate=1.0) | ||
| events = capture_events() | ||
|
|
||
| scope = sentry_sdk.get_current_scope() | ||
| scope.set_conversation_id("conv-no-op-but-data-test") | ||
|
|
||
| with sentry_sdk.start_transaction(name="test-tx"): | ||
| with start_span(name="unnamed-span") as span: | ||
| span.set_data("gen_ai.operation.name", "embedding") | ||
|
|
||
| (event,) = events | ||
| span_data = event["spans"][0]["data"] | ||
| assert span_data.get("gen_ai.conversation.id") == "conv-no-op-but-data-test" | ||
|
|
||
|
|
||
| def test_conversation_id_propagates_to_transaction_with_ai_op( | ||
| sentry_init, capture_events | ||
| ): | ||
| """Transaction with ai.* op should get conversation_id.""" | ||
| sentry_init(traces_sample_rate=1.0) | ||
| events = capture_events() | ||
|
|
||
| scope = sentry_sdk.get_current_scope() | ||
| scope.set_conversation_id("conv-tx-ai-op-test") | ||
|
|
||
| with sentry_sdk.start_transaction(op="ai.workflow", name="AI Workflow"): | ||
| pass | ||
|
|
||
| (event,) = events | ||
| trace_data = event["contexts"]["trace"]["data"] | ||
| assert trace_data.get("gen_ai.conversation.id") == "conv-tx-ai-op-test" | ||
|
|
||
|
|
||
| def test_conversation_id_not_propagated_to_non_ai_transaction( | ||
| sentry_init, capture_events | ||
| ): | ||
| """Non-AI transaction should NOT get conversation_id.""" | ||
| sentry_init(traces_sample_rate=1.0) | ||
| events = capture_events() | ||
|
|
||
| scope = sentry_sdk.get_current_scope() | ||
| scope.set_conversation_id("conv-tx-should-not-appear") | ||
|
|
||
| with sentry_sdk.start_transaction(op="http.server", name="HTTP Request"): | ||
| pass | ||
|
|
||
| (event,) = events | ||
| trace_data = event["contexts"]["trace"]["data"] | ||
| assert "gen_ai.conversation.id" not in trace_data | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.